Skip to content

fix(agent-manager): unify toolbar control heights and spacing - #13366

Merged
marius-kilocode merged 4 commits into
mainfrom
improve-context-button-consistency
Aug 24, 2026
Merged

fix(agent-manager): unify toolbar control heights and spacing#13366
marius-kilocode merged 4 commits into
mainfrom
improve-context-button-consistency

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

The Agent Manager toolbar mixed control geometries: the Run button rendered taller than the surrounding icon buttons, its dropdown chevron was a squeezed one-off variant, the diff toggle used its own height, corner radius, and hover color, and split chevrons sat at different distances from the control they belong to. Because several buttons only appear when their feature is available (PR, document viewer, subagents, review), nearly every session showed a differently shaped toolbar row.

Toolbar controls now share one geometry. Every button renders at the icon-button height, spacing comes only from the toolbar container gap so any subset of optional buttons stays evenly spaced, and the Run, terminal, new-session, and worktree split buttons use the same chevron with the same offset from their icon or label. The diff toggle drops its custom radius and hover color in favor of the shared tokens. The Storybook coverage also includes a deterministic full-context state with every optional toolbar action visible.

Before, with PR, document viewer, and subagent actions visible:

Agent Manager toolbar before with PR, document viewer, and subagent actions

After, with PR, document viewer, and subagent actions visible:

Agent Manager toolbar after with PR, document viewer, and subagent actions

@kilo-code-bot

kilo-code-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (8 files)
  • .changeset/agent-manager-toolbar-consistency.md
  • packages/kilo-vscode/webview-ui/agent-manager/TabBar.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
  • packages/kilo-vscode/webview-ui/src/stories/agent-manager.stories.tsx
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/multi-project-sidebar-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/tab-bar-full-context-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/tab-bar-multiple-tabs-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/tab-bar-single-tab-chromium-linux.png
Previous Review Summary (commit d808e30)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit d808e30)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • .changeset/agent-manager-toolbar-consistency.md
  • packages/kilo-vscode/webview-ui/agent-manager/TabBar.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/multi-project-sidebar-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/tab-bar-multiple-tabs-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/tab-bar-single-tab-chromium-linux.png

Reviewed by grok-4.6 · Input: 91.8K · Output: 5.9K · Cached: 273.4K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 1d790b4 into main Aug 24, 2026
26 checks passed
@marius-kilocode
marius-kilocode deleted the improve-context-button-consistency branch August 24, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants