Skip to content

test(cli): validate PTY across release targets - #13363

Merged
marius-kilocode merged 7 commits into
mainfrom
set-agent-manager-panel-default
Aug 24, 2026
Merged

test(cli): validate PTY across release targets#13363
marius-kilocode merged 7 commits into
mainfrom
set-agent-manager-panel-default

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

PTY support for Agent Manager is exercised differently from the regular CLI test suite. The previous live PTY tests skipped Windows, and release validation only started the compiled binaries, so native failures in ConPTY or musl targets could pass validation and surface after distribution.

This change adds portable coverage for both PTY API paths used by Agent Manager: regular terminal tabs and Run/setup terminals. Release validation now runs a release-only probe against every packaged CLI architecture and libc target before VSIX packaging. The probe covers shell startup, terminal I/O, resize, exit status, and cleanup.

Process-tree cleanup also reads Linux /proc directly when available, avoiding a dependency on ps in minimal musl environments. Windows cleanup avoids the Unix-only process-tree verifier after taskkill completes.

The Agent Manager terminal destination default is unchanged. This PR adds cross-platform validation and platform cleanup hardening only.

@marius-kilocode
marius-kilocode marked this pull request as ready for review August 24, 2026 13:02
@kilo-code-bot

kilo-code-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • packages/core/src/kilocode/pty/termination.ts
Previous Review Summaries (2 snapshots, latest commit 05cbbdd)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 05cbbdd)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
packages/core/src/kilocode/pty/termination.ts 135 /proc scan fails closed on a single vanished PID
Files Reviewed (3 files)
  • packages/core/src/kilocode/pty/smoke.ts - 0 issues
  • packages/core/src/kilocode/pty/termination.ts - 1 issue
  • packages/core/test/kilocode/pty-platform.test.ts - 0 issues

Fix these issues in Kilo Cloud

Previous review (commit 8d0750f)

Status: 4 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 3
SUGGESTION 1
Issue Details (click to expand)

WARNING

File Line Issue
packages/core/src/kilocode/pty/smoke.ts 20 Ready check can pass on echoed input before the shell runs
packages/core/src/kilocode/pty/smoke.ts 64 Cleanup probe will fail Alpine/musl release validation (ps -axo vs BusyBox)
packages/core/test/kilocode/pty-platform.test.ts 75 Exact taskkill exit code 128 is a brittle liveness check

SUGGESTION

File Line Issue
.github/workflows/test.yml 192 Dedicated PTY steps do not isolate these tests from the sharded suites
Files Reviewed (9 files)
  • .github/workflows/publish.yml - 0 issues
  • .github/workflows/test.yml - 1 issue
  • packages/core/src/kilocode/pty/smoke.ts - 2 issues
  • packages/core/src/kilocode/pty/termination.ts - 0 issues
  • packages/core/test/kilocode/pty-platform.test.ts - 1 issue
  • packages/opencode/src/kilocode/cli/cmd/pty-smoke.ts - 0 issues
  • packages/opencode/src/kilocode/cli/setup.ts - 0 issues
  • packages/opencode/test/server/httpapi-pty.test.ts - 0 issues
  • packages/opencode/test/server/httpapi-v2-pty.test.ts - 0 issues

Fix these issues in Kilo Cloud


Reviewed by grok-4.6 · Input: 70.7K · Output: 5.2K · Cached: 161.5K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit eacdff9 into main Aug 24, 2026
45 of 48 checks passed
@marius-kilocode
marius-kilocode deleted the set-agent-manager-panel-default branch August 24, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants