test(cli): validate PTY across release targets - #13363
Merged
Merged
Conversation
marius-kilocode
marked this pull request as ready for review
August 24, 2026 13:02
marius-kilocode
enabled auto-merge
August 24, 2026 13:02
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Previous Review Summaries (2 snapshots, latest commit 05cbbdd)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 05cbbdd)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (3 files)
Fix these issues in Kilo Cloud Previous review (commit 8d0750f)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (9 files)
Reviewed by grok-4.6 · Input: 70.7K · Output: 5.2K · Cached: 161.5K Review guidance: REVIEW.md from base branch |
kirillk
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTY support for Agent Manager is exercised differently from the regular CLI test suite. The previous live PTY tests skipped Windows, and release validation only started the compiled binaries, so native failures in ConPTY or musl targets could pass validation and surface after distribution.
This change adds portable coverage for both PTY API paths used by Agent Manager: regular terminal tabs and Run/setup terminals. Release validation now runs a release-only probe against every packaged CLI architecture and libc target before VSIX packaging. The probe covers shell startup, terminal I/O, resize, exit status, and cleanup.
Process-tree cleanup also reads Linux
/procdirectly when available, avoiding a dependency onpsin minimal musl environments. Windows cleanup avoids the Unix-only process-tree verifier aftertaskkillcompletes.The Agent Manager terminal destination default is unchanged. This PR adds cross-platform validation and platform cleanup hardening only.