fix(cli): gate prompt cache breakpoints to first-party OpenAI providers - #13321
Open
maphew wants to merge 6 commits into
Open
fix(cli): gate prompt cache breakpoints to first-party OpenAI providers#13321maphew wants to merge 6 commits into
maphew wants to merge 6 commits into
Conversation
Custom providers using the @ai-sdk/openai package with gpt-5.6+ model ids were getting promptCacheBreakpoint injected, which their endpoints reject with HTTP 400 (prompt_cache_breakpoint is not supported on this model). Only apply explicit breakpoints for the OpenAI API, Azure OpenAI, and Kilo Gateway, where the parameter is known to be supported.
maphew
force-pushed
the
fix/openai-custom-provider-cache-breakpoint
branch
from
August 22, 2026 05:15
6d573d3 to
03fd0bb
Compare
maphew
marked this pull request as ready for review
August 22, 2026 16:33
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03fd0bbd04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (6 files)
Previous Review Summaries (2 snapshots, latest commit d102998)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit d102998)Status: No Issues Found | Recommendation: Merge Files Reviewed (6 files)
Previous review (commit 03fd0bb)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by grok-4.6 · Input: 68.8K · Output: 7.4K · Cached: 418K Review guidance: REVIEW.md from base branch |
…mirror Address two review findings on the prompt_cache_breakpoint allowlist: 1. A custom endpoint override (provider options endpoint/baseURL) on a first-party provider ID reroutes requests through a proxy that may reject prompt_cache_breakpoint. Thread the override into messageTransformOptions (kept out of wire params) and only apply breakpoints when the resolved host is first-party for that provider. Azure keeps its legitimate endpoint overrides on *.azure.com, *.azure.us, *.azure.cn, and *.azure-api.net hosts. 2. Move the regression test into the Kilo-owned test mirror (test/kilocode/provider/transform.test.ts) per the fork isolation rule, and extend it with override, unparseable-URL, azure-host, and first-party positive coverage. Agent-Signature: claude-fable-5-high on behalf of matt wilkie
Agent-Signature: kilo-auto/efficient on behalf of maphew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13285.
What
Since #13022 (v7.4.21+), Kilo injects
promptCacheBreakpoint: { mode: "explicit" }into OpenAI/@ai-sdk/openaiprovider options for any model id matchinggpt-5.6+. The gate only checked the model id (plus a zero-cost ChatGPT-subscription heuristic), so custom providers that use the@ai-sdk/openaipackage against their own endpoint also received the parameter — and many of those endpoints reject it with HTTP 400:The issue reproduces with
gpt-5.6-sol/gpt-5.6-terraon a custom@ai-sdk/openaiprovider (confirmed on a fresh VM, stable across 7.4.22/7.4.23, gone when rolling back to 7.4.20).Why
prompt_cache_breakpointis only known to be supported by first-party OpenAI-family deployments. Sending it to arbitrary OpenAI-compatible endpoints breaks every request, which is worse than the cache savings it buys. Restrict the breakpoint to the deployments that actually support it: OpenAI API (openai), Azure OpenAI (azure), and Kilo Gateway (kilo).Checks
packages/opencode:bun test ./test/provider/transform.test.ts— 421 pass (incl. new regression test)packages/opencode:bun run typecheck— cleanbun run script/check-opencode-annotations.ts --worktree— cleanRelated
prompt_cache_retentionon GPT-5.6 Luna via the OpenAI Subscription) is a related but separate class — different parameter, different code path (subagent/promptCacheKeyhandling, not the breakpoint gate) — and is not addressed here.-terravariants); this gates at the provider level instead, which also covers-soland any future gpt-6.x custom models.Note: the repo pre-push hook's JetBrains typecheck could not complete in this sandbox (Gradle distribution download fails against the sandbox proxy cert). The push was made with
--no-verifyafter the JetBrains-irrelevant checks above passed.