fix(jetbrains): keep slash completion open while typing - #13287
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (9 files)
Reviewed by grok-4.6 · Input: 535.3K · Output: 26.5K · Cached: 641.5K Review guidance: REVIEW.md from base branch |
kirillk
enabled auto-merge
August 20, 2026 20:48
WebReflection
approved these changes
Aug 21, 2026
WebReflection
left a comment
There was a problem hiding this comment.
I couldn't find anything obviously wrong + there are tests and because Anil would've approved I'm going to give this a thumb up
Contributor
Author
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No linked issue; reported from the JetBrains slash command fast-typing session.
Context
JetBrains slash command completion can close while typing quickly. The slash path filters commands from in-memory state and finishes immediately, while
@mentions stay in completion calculation during backend file search. When the slash lookup closes mid-token, the existing first-character trigger does not reopen it.The prompt should also regain focus after choosing a model, agent, or reasoning option opened from a slash command, so users can keep typing without clicking back into the prompt.
Implementation
No matchesresults can update to real server commands.PickerButton, then wire model, agent, and reasoning pickers to refocus the prompt after a selection.The reopen path is limited to single-character typing so programmatic prompt text updates and paste operations do not automatically open completion.
Screenshots / Video
N/A — behavior and focus fix; no visual UI change.
How to Test
Manual/local verification
./gradlew typecheckfrompackages/kilo-jetbrains/../gradlew --no-configuration-cache :frontend:testfrompackages/kilo-jetbrains/.Reviewer test steps
/models, and confirm the completion popup stays open or reopens while filtering./models, an agent via/agents, and a reasoning option via/variant; after each selection, confirm focus returns to the prompt.Blocked checks and substitute verification
./gradlew :frontend:testimmediately after./gradlew typecheck; Gradle IntelliJ instrumentation failed withclassname attribute of taskdef element is undefined/No Java Compiler dependency found, consistent with a configuration-cache dependency resolution issue. Substitute verification: reran./gradlew --no-configuration-cache :frontend:test, which passed.Checklist
Get in Touch
N/A