fix(cli): scope interactive terminal state - #13236
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by grok-4.6 · Input: 196.1K · Output: 115.2K · Cached: 1.5M Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
August 19, 2026 11:58
johnnyeric
approved these changes
Aug 19, 2026
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interactive terminal state previously relied on a per-instance singleton, which made lifecycle ownership harder to reason about and left initialization vulnerable to concurrent first access. This change provides directory-scoped terminal services with coalesced initialization and explicit PTY cleanup when an instance or runtime scope closes.
The terminal API and behavior remain unchanged for launch, input, resize, close, takeover, abort, output, and per-directory isolation. Focused lifecycle tests cover concurrent initialization, cross-directory isolation, and disposal cleanup.