Skip to content

fix(cli): scope interactive terminal state - #13236

Merged
marius-kilocode merged 1 commit into
mainfrom
refactor-interactive-terminal-service
Aug 19, 2026
Merged

fix(cli): scope interactive terminal state#13236
marius-kilocode merged 1 commit into
mainfrom
refactor-interactive-terminal-service

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

Interactive terminal state previously relied on a per-instance singleton, which made lifecycle ownership harder to reason about and left initialization vulnerable to concurrent first access. This change provides directory-scoped terminal services with coalesced initialization and explicit PTY cleanup when an instance or runtime scope closes.

The terminal API and behavior remain unchanged for launch, input, resize, close, takeover, abort, output, and per-directory isolation. Focused lifecycle tests cover concurrent initialization, cross-directory isolation, and disposal cleanup.

@kilo-code-bot

kilo-code-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • .changeset/scoped-interactive-terminal-state.md
  • packages/opencode/src/kilocode/interactive-terminal/index.ts
  • packages/opencode/test/kilocode/interactive-terminal.test.ts
  • script/architecture-allowlist.json

Reviewed by grok-4.6 · Input: 196.1K · Output: 115.2K · Cached: 1.5M

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit a59260b into main Aug 19, 2026
33 checks passed
@marius-kilocode
marius-kilocode deleted the refactor-interactive-terminal-service branch August 19, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants