Skip to content

refactor(cli): scope project ID cache lifecycle - #13234

Merged
marius-kilocode merged 1 commit into
mainfrom
refactor-project-id-service
Aug 19, 2026
Merged

refactor(cli): scope project ID cache lifecycle#13234
marius-kilocode merged 1 commit into
mainfrom
refactor-project-id-service

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

Project ID resolution used InstanceState.make inside a Kilo service layer, which left lifecycle ownership tied to the ambient instance-state singleton. This prevented the service from owning its cache explicitly and left the architecture ratchet exception in place.

The service now owns an Effect cache keyed by project directory, invalidates only the disposed directory through the existing instance disposal lifecycle, and unregisters the disposal hook when the service scope closes. Resolution priority and public callers remain unchanged. Focused coverage protects concurrent project isolation and cache refresh after disposal.

@kilo-code-bot

kilo-code-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • packages/opencode/src/kilocode/project-id.ts
  • packages/opencode/test/kilocode/project-id.test.ts
  • script/architecture-allowlist.json

Reviewed by grok-4.6 · Input: 155.1K · Output: 41.3K · Cached: 843.1K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit b14a21c into main Aug 19, 2026
32 checks passed
@marius-kilocode
marius-kilocode deleted the refactor-project-id-service branch August 19, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants