test(core): make project copy cleanup idempotent - #13211
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by grok-4.6 · Input: 29.3K · Output: 4.4K · Cached: 169K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
August 18, 2026 14:44
johnnyeric
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ProjectCopy regression test removes its temporary checkout's
.gitdirectory to verify refresh behavior after Git metadata disappears. The removal was not idempotent, so macOS CI could fail before the behavior under test withENOENTwhen cleanup raced with temporary filesystem teardown.Use forced recursive removal for that deliberately absent-tolerant test setup. This preserves the regression scenario while preventing unrelated cleanup races from failing Core CI.