fix(vscode): keep permission prompt actions reachable with large diffs - #13201
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge lgtm — the flex-layout approach is sound: the margin-collapse compensation (banner/prompt-input) matches the pre-change spacing exactly, the specificity ordering between the Files Reviewed (17 files)
Reviewed by kimi-k3 · Input: 213.3K · Output: 15.7K · Cached: 1.8M Review guidance: REVIEW.md from base branch |
johnnyeric
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13191
A permission card can be taller than the space left below the transcript: the title, description, an inline diff capped at 420px, the Allow/Deny row and the auto-approve tray easily add up to ~500px. The card lives in
.chat-input, which wasflex-shrink: 0inside a.chat-viewthat clips its overflow, so the card kept its full height, the transcript collapsed to zero, and the bottom of the card was simply cut off by the panel edge. The only scroll containers were inside the diff itself, so there was nothing to scroll to bring the buttons back.The result is a blocked session: with a short chat area (a large bottom panel in Agent Manager, a small window, or a bigger editor font) the ask can only be answered through the Enter/Escape shortcuts, which are not discoverable and which many users will not try while looking for a button.
Behavior this introduces:
Spacing, sizing and the appearance of the card in a roomy panel are unchanged.
Before and after
A
+150 −0edit ask in a 515px-high chat area. Before, the card runs past the panel edge: no Allow/Deny, no tray, no composer, and no scrollbar anywhere. After, the diff preview shrinks and scrolls while the buttons, tray and composer stay in place.The same ask in a panel with room to spare, where the card looks as it did before:
The committed visual-regression baselines for the
permission-dock-editandpermission-dock-apply-patchstories still show the truncated card, since those stories renderChatViewin 350px and 420px containers. They need to be regenerated with this change.