Skip to content

fix(cli): preserve Kilo upgrade version lookup - #13199

Merged
marius-kilocode merged 2 commits into
mainfrom
cosmic-oval
Aug 18, 2026
Merged

fix(cli): preserve Kilo upgrade version lookup#13199
marius-kilocode merged 2 commits into
mainfrom
cosmic-oval

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

Problem

kilo upgrade can resolve the wrong target when GitHub's releases/latest points to a JetBrains release such as jetbrains/v7.0.16. The curl installer then receives a non-CLI tag and fails instead of upgrading the Kilo CLI.

Regression history

Change

Keep the Kilo curl/unknown fallback in Kilo-owned code and leave the shared installation service with a minimal marked integration point. Add a regression test that simulates GitHub returning jetbrains/v7.0.16 and verifies that the Kilo npm registry supplies the version without requesting the polluted GitHub endpoint.

This makes the behavior explicit in Kilo-owned code and causes CI to catch any future OpenCode merge that restores the upstream lookup.

Comment thread packages/opencode/src/kilocode/installation/latest.ts
@kilo-code-bot

kilo-code-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The previous suggestion (missing rationale comment in packages/opencode/src/kilocode/installation/latest.ts) was resolved in dfd7a48 — the helper now documents why the npm registry is used instead of GitHub releases/latest.

Files Reviewed (4 files)
  • .changeset/restore-kilo-upgrade-version-lookup.md
  • packages/opencode/src/installation/index.ts
  • packages/opencode/src/kilocode/installation/latest.ts
  • packages/opencode/test/kilocode/installation/upgrade.test.ts
Previous Review Summary (commit 6131ed2)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 6131ed2)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/opencode/src/kilocode/installation/latest.ts 6 Extracted helper drops the rationale comment explaining why GitHub releases/latest is avoided
Files Reviewed (4 files)
  • .changeset/restore-kilo-upgrade-version-lookup.md
  • packages/opencode/src/installation/index.ts
  • packages/opencode/src/kilocode/installation/latest.ts - 1 issue
  • packages/opencode/test/kilocode/installation/upgrade.test.ts

The extraction is clean: fork hygiene is good (single kilocode_change marker line in the shared file, logic moved to Kilo-owned path), the unused GitHubRelease schema was removed with no remaining references, the regression test correctly fails if the upstream GitHub lookup is ever restored, and the changeset is present with user-facing wording. No memory-leak concerns — the change introduces no subscriptions, caches, or long-lived resources.

Fix these issues in Kilo Cloud


Reviewed by kimi-k3 · Input: 40.6K · Output: 2K · Cached: 169.1K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit e4058bf into main Aug 18, 2026
33 checks passed
@marius-kilocode
marius-kilocode deleted the cosmic-oval branch August 18, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants