fix(vscode): preserve cached reasoning variants - #13174
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Minimal, correct fix. The removed sentinel write in Files Reviewed (3 files)
Reviewed by kimi-k3 · Input: 95K · Output: 8.6K · Cached: 405.4K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
August 17, 2026 12:46
johnnyeric
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default reasoning support introduced a sentinel value for explicit model-default selections. Model changes also pass through the variant carry path, where an absent current value was persisted as that sentinel. Because session resolution gives the session/model key precedence over the agent/model cache, new sessions could lose the previously selected reasoning effort.
This changes the carry path to leave the cache untouched when there is no concrete variant to carry. Explicit user selection of Default continues to persist the sentinel through the select path. Regression coverage covers both global new-session state and session-scoped state.
The introducing change was PR #13063.