Skip to content

feat(vscode): show token throughput by default - #13164

Merged
marius-kilocode merged 1 commit into
mainfrom
make-ts-default-with-toggle
Aug 17, 2026
Merged

feat(vscode): show token throughput by default#13164
marius-kilocode merged 1 commit into
mainfrom
make-ts-default-with-toggle

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

Token throughput in the VS Code chat is currently opt-in, so generation-rate metadata is absent for new installations even though the UI includes a display control.

This changes the VS Code setting default and all fallback and hydration paths to enabled. An explicitly persisted false value remains authoritative, allowing users to hide the rate from Display settings. Localized descriptions now reflect the enabled default, and focused coverage protects both the default and opt-out behavior.

@kilo-code-bot

kilo-code-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

lgtm — the default flip is coherent across all four paths that can diverge: package.json default (true), the extension message builder fallback in throughput-settings.ts (config.get(..., true)), the webview initial signal in display.tsx (createSignal(true)), and the DisplayTab switch (?? true). An explicitly persisted false in user settings still wins, since the VS Code fallback only applies when the key is unset. All 22 locale descriptions were updated consistently, the changeset is user-facing, and the new unit test follows the established autocomplete-settings-message.test.ts stubbing pattern while exercising the real buildThroughputSettingMessage. No new subscriptions, timers, or processes — no memory-leak surface introduced.

Files Reviewed (27 files)
  • .changeset/show-token-throughput-by-default.md
  • packages/kilo-vscode/package.json
  • packages/kilo-vscode/src/kilo-provider/throughput-settings.ts
  • packages/kilo-vscode/tests/unit/throughput-settings-message.test.ts
  • packages/kilo-vscode/webview-ui/src/components/settings/DisplayTab.tsx
  • packages/kilo-vscode/webview-ui/src/context/display.tsx
  • packages/kilo-vscode/webview-ui/src/i18n/*.ts (21 locale files)

Reviewed by kimi-k3 · Input: 63.9K · Output: 5.5K · Cached: 559.7K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 2ae7d73 into main Aug 17, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the make-ts-default-with-toggle branch August 17, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants