fix(tui): preserve provider category groups in model picker - #13133
Closed
md-abusayeed wants to merge 1 commit into
Closed
fix(tui): preserve provider category groups in model picker#13133md-abusayeed wants to merge 1 commit into
md-abusayeed wants to merge 1 commit into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous Review Summary (commit b0832fd)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit b0832fd)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by grok-4.6 · Input: 41.4K · Output: 3.5K · Cached: 91.9K Review guidance: REVIEW.md from base branch |
md-abusayeed
force-pushed
the
fix/model-picker-provider-grouping
branch
from
August 20, 2026 04:12
b0832fd to
07d2b40
Compare
Contributor
|
Thanks for working on this, @md-abusayeed. The overlapping model-picker fix landed in #13170 and shipped in v7.4.23, so I’m closing this PR as superseded since the current diff adds no runtime fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13123
Summary
When models were present in favorites or recents, the model picker filtered them out of the provider list. For custom providers with small catalogs (e.g. 1 or 2 models defined in global
kilo.json), selecting those models placed all of them in recents, causing the entire custom provider category group to disappear from the model selector.Changes
packages/tui/test/kilocode/model-picker.test.tsverifying that custom provider category headers remain intact when all their models are in recent selections (Custom Provider in Globalkilo.jsonNot Appearing as Group in Model Picker #13123)..changeset/model-picker-provider-grouping.md.