Skip to content

fix(tui): preserve provider category groups in model picker - #13133

Closed
md-abusayeed wants to merge 1 commit into
Kilo-Org:mainfrom
md-abusayeed:fix/model-picker-provider-grouping
Closed

fix(tui): preserve provider category groups in model picker#13133
md-abusayeed wants to merge 1 commit into
Kilo-Org:mainfrom
md-abusayeed:fix/model-picker-provider-grouping

Conversation

@md-abusayeed

@md-abusayeed md-abusayeed commented Aug 15, 2026

Copy link
Copy Markdown

Fixes #13123

Summary

When models were present in favorites or recents, the model picker filtered them out of the provider list. For custom providers with small catalogs (e.g. 1 or 2 models defined in global kilo.json), selecting those models placed all of them in recents, causing the entire custom provider category group to disappear from the model selector.

Changes

@kilo-code-bot

kilo-code-bot Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • .changeset/model-picker-provider-grouping.md
  • packages/tui/src/component/dialog-model.tsx
  • packages/tui/test/cli/cmd/tui/model-options.test.ts
Previous Review Summary (commit b0832fd)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit b0832fd)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • .changeset/model-picker-provider-grouping.md
  • packages/tui/src/component/dialog-model.tsx
  • packages/tui/test/cli/cmd/tui/model-options.test.ts

Reviewed by grok-4.6 · Input: 41.4K · Output: 3.5K · Cached: 91.9K

Review guidance: REVIEW.md from base branch main

@md-abusayeed
md-abusayeed force-pushed the fix/model-picker-provider-grouping branch from b0832fd to 07d2b40 Compare August 20, 2026 04:12
@johnnyeric

Copy link
Copy Markdown
Contributor

Thanks for working on this, @md-abusayeed. The overlapping model-picker fix landed in #13170 and shipped in v7.4.23, so I’m closing this PR as superseded since the current diff adds no runtime fix.

@johnnyeric johnnyeric closed this Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom Provider in Global kilo.json Not Appearing as Group in Model Picker

2 participants