fix(tui): stop leftover toast titles during update install - #13114
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Incremental review of Files Reviewed (14 files)
Previous Review Summary (commit f0eb9d1)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit f0eb9d1)Status: No Issues Found | Recommendation: Merge lgtm — the Files Reviewed (4 files)
Reviewed by kimi-k3 · Input: 96.2K · Output: 8.2K · Cached: 556.6K Review guidance: REVIEW.md from base branch |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0eb9d10ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
de6f390 to
cd35c4e
Compare
SolidJS store merge kept the previous toast title when the next toast omitted it, so the update prompt reused "MCP Authentication Required".
cd35c4e to
1213fd1
Compare
…13114) SolidJS store merge kept the previous toast title when the next toast omitted it, so the update prompt reused "MCP Authentication Required".
What
When accepting the TUI update prompt, the installing notification reused the previous toast title (
MCP Authentication Required) instead of an update title.Why
SolidJS
createStoremerges objects, socurrentToast.titleleaked from the last toast when the update toast omittedtitle.Change
reconcileso omitted fields do not persistUpdatingtitle on the install toastHow to Test
Updating, not the MCP title