refactor(cli): rely on catalog model variants - #13103
Conversation
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
| { | ||
| reasoningEffort: effort, | ||
| reasoningSummary: reasoningSummary(model), // kilocode_change | ||
| reasoningSummary: "auto", |
There was a problem hiding this comment.
CRITICAL: The gpt-5.6 detailed-summary kilocode_change was moved to the wrong case
In the base, the @ai-sdk/openai / @ai-sdk/amazon-bedrock/mantle branch (this one) used reasoningSummary: reasoningSummary(model) so that GPT-5.6 variants on direct OpenAI get reasoningSummary: "detailed". This PR moved the reasoningSummary(model) call up into the @ai-sdk/github-copilot branch (line 984) and reverted this branch to "auto".
Two consequences:
reasoningSummary()(insrc/kilocode/provider/reasoning-summary.ts) returns"auto"for any npm other than@ai-sdk/openai, so in the github-copilot branch it is a no-op — the kilocode behavior is effectively lost, not relocated.- The retained test
packages/opencode/test/kilocode/provider/gpt-5.6-summary.test.ts("requests detailed summaries for every direct OpenAI reasoning variant") asserts every variant fromProviderTransform.variants()for gpt-5.6 on@ai-sdk/openaihasreasoningSummary === "detailed"— it will now fail against this branch.
This looks like an accidental swap of two adjacent, similar-looking hunks during the revert. Suggest restoring the marker here and reverting the copilot branch to upstream "auto":
| reasoningSummary: "auto", | |
| reasoningSummary: reasoningSummary(model), // kilocode_change |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
There was a problem hiding this comment.
Fixed in 81e30df: direct OpenAI variants use reasoningSummary(model), while GitHub Copilot remains on the upstream auto value.
| { | ||
| reasoningEffort: effort, | ||
| reasoningSummary: "auto", | ||
| reasoningSummary: reasoningSummary(model), // kilocode_change |
There was a problem hiding this comment.
SUGGESTION: This kilocode_change is a no-op in the github-copilot branch
reasoningSummary() only returns something other than "auto" when model.api.npm === "@ai-sdk/openai"; this branch handles @ai-sdk/github-copilot models, so reasoningSummary(model) here always evaluates to "auto". It appears this marker was accidentally swapped with the one that belongs in the @ai-sdk/openai branch below (see the comment on line 1044). Once that is restored, this line should go back to the upstream value to keep the diff minimal:
| reasoningSummary: reasoningSummary(model), // kilocode_change | |
| reasoningSummary: "auto", |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
There was a problem hiding this comment.
Fixed in 81e30df: the no-op Copilot change was reverted to reasoningSummary: "auto".
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Incremental review of The test change expands the custom-provider fallback coverage to a 3-package × 4-model-ID matrix; expectations match Files Reviewed (2 files)
Previous Review Summaries (2 snapshots, latest commit 7b48fc4)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 7b48fc4)Status: No Issues Found | Recommendation: Merge Incremental review of The test change expands the custom-provider fallback coverage to a 3-package × 4-model-ID matrix; expectations match Files Reviewed (2 files)
Previous review (commit 81e30df)Status: No Issues Found | Recommendation: Merge The two findings from the previous review (gpt-5.6 Spot-checked the result against upstream opencode v1.18.13: Files Reviewed (5 files)
Reviewed by kimi-k3 · Input: 55K · Output: 1.6K · Cached: 101.4K Review guidance: REVIEW.md from base branch |
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Remove Kilo-specific model-name heuristics that diverged from OpenCode v1.18.13 while retaining the package-based broad reasoning fallback for explicitly configured custom providers.
Bundled model variants now come from models.dev reasoning metadata, explicit configuration, or the Kilo Gateway catalog. Unknown GLM, Kimi, MiniMax, and Qwen IDs on supported custom-provider packages remain covered by the broad fallback.