Skip to content

feat(vscode): improve custom provider dialog layout and model toggles - #13046

Merged
chrarnoldus merged 4 commits into
mainfrom
resolute-cattle
Aug 10, 2026
Merged

feat(vscode): improve custom provider dialog layout and model toggles#13046
chrarnoldus merged 4 commits into
mainfrom
resolute-cattle

Conversation

@chrarnoldus

Copy link
Copy Markdown
Collaborator

Summary of changes

  • Dialog layout & spacing: Updated CustomProviderDialog to use size="large", configured large/x-large dialog max-width and max-height constraints in packages/kilo-ui/src/components/dialog.css, and cleaned up padding so the dialog uses more viewport space.
  • Advanced settings button: Replaced the plain link with an interactive secondary Button with an edit icon, making the action to edit advanced JSON settings clearly prominent and clickable.
  • Bulk model capability toggles: Added "Toggle reasoning for all" and "Toggle image for all" buttons to the models section header in CustomProviderDialog with complete translations across all supported locales, allowing single-click toggling across all configured models.

@chrarnoldus chrarnoldus self-assigned this Aug 10, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Incremental review of 97d0c97 (changes since 9816009): the previous suggestion (add a Storybook story for the reworked dialog) is resolved. The new CustomProviderCreateDialog and CustomProviderEditDialog stories follow the established useDialog + onMount pattern from anaconda-desktop.stories.tsx, the mock existing data matches the ProviderConfig shape with a valid CustomProviderPackage, and StoryProviders supplies the required DialogProvider. The committed Linux baselines match the visual-regression spec's auto-discovery naming (settings--custom-provider-{create,edit}-dialog). No memory-leak surface introduced — dialog lifetime is owned by DialogProvider inside the story tree, with no timers, subscriptions, or listeners added.

Files Reviewed (3 files)
  • packages/kilo-vscode/webview-ui/src/stories/settings.stories.tsx
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/settings/custom-provider-create-dialog-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/settings/custom-provider-edit-dialog-chromium-linux.png
Previous Review Summary (commit 9816009)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 9816009)

Status: No Issues Found | Recommendation: Merge

The previous suggestion (add a Storybook story for the reworked dialog) is resolved: commit 3a9f5a6 adds CustomProviderCreateDialog and CustomProviderEditDialog stories following the established useDialog + onMount pattern, with mock data matching the ProviderConfig shape and all required contexts supplied by StoryProviders. No memory-leak surface introduced (dialog lifetime is owned by DialogProvider inside the story tree).

Files Reviewed (27 files)
  • .changeset/custom-provider-edit-screen-improvements.md
  • packages/kilo-ui/src/components/dialog.css
  • packages/kilo-vscode/tests/unit/custom-provider-dialog-validate.test.ts
  • packages/kilo-vscode/webview-ui/src/components/settings/CustomProviderDialog.tsx
  • packages/kilo-vscode/webview-ui/src/components/settings/CustomProviderModelCard.tsx
  • packages/kilo-vscode/webview-ui/src/stories/settings.stories.tsx
  • packages/kilo-vscode/webview-ui/src/i18n/ar.ts
  • packages/kilo-vscode/webview-ui/src/i18n/br.ts
  • packages/kilo-vscode/webview-ui/src/i18n/bs.ts
  • packages/kilo-vscode/webview-ui/src/i18n/da.ts
  • packages/kilo-vscode/webview-ui/src/i18n/de.ts
  • packages/kilo-vscode/webview-ui/src/i18n/en.ts
  • packages/kilo-vscode/webview-ui/src/i18n/es.ts
  • packages/kilo-vscode/webview-ui/src/i18n/fa.ts
  • packages/kilo-vscode/webview-ui/src/i18n/fr.ts
  • packages/kilo-vscode/webview-ui/src/i18n/it.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ja.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ko.ts
  • packages/kilo-vscode/webview-ui/src/i18n/nl.ts
  • packages/kilo-vscode/webview-ui/src/i18n/no.ts
  • packages/kilo-vscode/webview-ui/src/i18n/pl.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ru.ts
  • packages/kilo-vscode/webview-ui/src/i18n/th.ts
  • packages/kilo-vscode/webview-ui/src/i18n/tr.ts
  • packages/kilo-vscode/webview-ui/src/i18n/uk.ts
  • packages/kilo-vscode/webview-ui/src/i18n/zh.ts
  • packages/kilo-vscode/webview-ui/src/i18n/zht.ts

Reviewed by kimi-k3 · Input: 143K · Output: 7.6K · Cached: 494.3K

Review guidance: REVIEW.md from base branch main

@chrarnoldus

Copy link
Copy Markdown
Collaborator Author
CleanShot 2026-08-10 at 15 44 16

@chrarnoldus
chrarnoldus merged commit d996623 into main Aug 10, 2026
44 of 46 checks passed
@chrarnoldus
chrarnoldus deleted the resolute-cattle branch August 10, 2026 14:22
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
feat(vscode): improve custom provider dialog layout and model toggles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants