fix(agent-manager): support llama.cpp tool schema - #12946
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The previous suggestion (retain the session ID format hint in the wire schema) was addressed in Files Reviewed (2 files)
Previous Review Summary (commit 24da90f)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 24da90f)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
The fix is correct and minimal: the wire schema drops the prefix-only Files Reviewed (3 files)
Reviewed by kimi-k3 · Input: 46K · Output: 4.1K · Cached: 244.7K Review guidance: REVIEW.md from base branch |
…macpp-schema fix(agent-manager): support llama.cpp tool schema
The Agent Manager advertises a prefix-only
^sespattern forsessionID. llama.cpp rejects that tool schema before inference because it requires patterns to be fully anchored.Expose
sessionIDas a plain string only in the model-facing wire schema while retaining the brandedSessionIDconstraint in the local execution schema. This keeps validation intact without applying provider-wide schema rewriting.Related to #12773.