feat(vscode): improve Agent Manager terminal navigation - #12945
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The incremental range merges Files Reviewed (4 files)
Previous Review Summaries (2 snapshots, latest commit e6b4313)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit e6b4313)Status: No Issues Found | Recommendation: Merge The new commit Files Reviewed (3 files)
Previous review (commit e9d7690)Status: 3 Issues Found | Recommendation: Address before merge Overview
The focus-aware terminal model is well-structured: state/handler logic is unit-tested against the real implementation, the three findings from the previous review round are all fixed in HEAD (cycle boundary seeding, Issue Details (click to expand)SUGGESTION
Files Reviewed (25 files)
Reviewed by kimi-k3 · Input: 57.7K · Output: 12.7K · Cached: 754.7K Review guidance: REVIEW.md from base branch |
| "agentManager.shortcuts.newTab": "New tab", | ||
| "agentManager.shortcuts.closeTab": "Close tab", | ||
| "agentManager.shortcuts.toggleTerminal": "Toggle terminal", | ||
| "agentManager.shortcuts.toggleTerminal": "Focus / hide terminal", |
There was a problem hiding this comment.
Should we create translations for this change?
…terminal-ux feat(vscode): improve Agent Manager terminal navigation
Agent Manager currently makes embedded terminal focus and terminal-tab ownership ambiguous. A visible side panel can receive keyboard actions without clearly owning focus, switching back to the prompt can require repeated input, and closing terminals can hide the wrong surface or stop the last shell.
This change establishes a focus-aware terminal model:
Cmd+/shows and focuses a hidden terminal, focuses a visible unfocused terminal, or hides a focused terminal.Cmd+Shift+Mfocuses the Agent Manager prompt and takes precedence over VS Code's Problems shortcut.Cmd+Shift+Tcreates a main terminal tab from prompt or main-terminal focus, and a side terminal tab only when a side terminal is focused.Cmd+Shift+[/]navigate terminals within the focused terminal strip.Cmd+Wpreserves the session when closing the last terminal and selects a surviving terminal after closing another.The behavior keeps agent-session shortcuts stable while making terminal actions predictable by focus.