docs(vscode): add icon authoring skill - #12872
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
|
|
||
| - Search `packages/kilo-ui/src/components/icon.tsx` first for Kilo-only icons, then `packages/ui/src/components/icon.tsx` for shared icons. Use the existing kebab-case name and visual sibling before adding a new one. | ||
| - Webview icons are inline SVG path strings, not standalone files. They use `fill="currentColor"` or `stroke="currentColor"`; never add a light/dark duplicate or a literal palette for these icons. | ||
| - Standard registry icons use a `20 20` viewBox and render at 16px (`small`), 20px (`normal`), or 24px (`medium`/`large`). Use a `16 16` viewBox only when matching an existing small-grid sibling or a role that requires it. Do not paste a 16px path into a 20px canvas without rebalancing it. |
There was a problem hiding this comment.
SUGGESTION: viewBox guidance omits the 24x24 icons in the Kilo registry
Line 22 sends authors to packages/kilo-ui/src/components/icon.tsx first, but 5 of that registry's 14 icons (memory, database, book-open-check, reload, gauge) use a 0 0 24 24 lucide-style canvas, while this line only describes 20 20 as the standard and 16 16 as the exception. An author whose closest sibling is one of those 24x24 icons gets no rule explaining when that canvas is acceptable. Consider noting that the Kilo registry also contains 24x24 lucide-style entries and that new icons should match their closest sibling's canvas (which rule 2 already implies).
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The previous suggestion (viewBox guidance omitting the 24x24 Kilo registry icons) was addressed in Files Reviewed (1 file)
Previous Review Summary (commit 5de420a)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 5de420a)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (1 file)
Reviewed by kimi-k3 · Input: 135.4K · Output: 8.4K · Cached: 684K Review guidance: REVIEW.md from base branch |
…generation-skill docs(vscode): add icon authoring skill
2 participants
Models currently have JetBrains-specific icon guidance but no equivalent for the VS Code extension, which makes it easy to apply the wrong light/dark, palette, and asset rules to webview icons.
Add a concise VS Code icon skill that distinguishes Codicons, packaged extension assets, and the currentColor-based kilo-ui registry. It documents the existing source paths, canvas and stroke normalization rules, registration boundaries, and the visual review workflow.