fix(vscode): speed up snapshot installs and isolate project state - #12871
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge All 4 previous findings were addressed in the latest commits: the project-directory guard now exempts Files Reviewed (6 files)
Previous Review Summary (commit 5a95577)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 5a95577)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (15 files)
Reviewed by kimi-k3 · Input: 216K · Output: 18.4K · Cached: 913.1K Review guidance: REVIEW.md from base branch |
…tall-parallelism # Conflicts: # .changeset/fix-multi-project-session-scope.md # packages/kilo-vscode/src/KiloProvider.ts # packages/kilo-vscode/tests/unit/kilo-provider-followup.test.ts
…tall-parallelism fix(vscode): speed up snapshot installs and isolate project state
Problem
Local
bun run snapshot:installruns a full SDK generation and CLI build on every invocation, serializes extension validation, compresses a large local-install VSIX, and clears the cached CLI binary. This makes the normal edit-install-test loop dominated by work that is unchanged between runs. Agent Manager project switching also allowed session events, session listings, and Git status to cross project boundaries or become stale after asynchronous refreshes.Changes
snapshot:buildVSIX files normally compressed.node_modulescache files, with target-specific FFmpeg reuse.Performance
The baseline was captured before the snapshot changes on the same worktree and machine. The cache-invalidating run rebuilds the CLI; the warm run reuses the compiled CLI and SDK outputs.
bun run snapshot:installbun run snapshot:installbun run snapshot:installStoredbun run snapshot:buildThe warm path is sensitive to host load because production bundling and VSIX packaging are CPU and I/O heavy. Earlier warm samples ranged from approximately 11.9s to 29.2s under contention; the final committed-code warm run above completed successfully.
Validation
bun run test:unitbun run typecheckbun run lintbun run knipbun run check-kilocode-changebun run snapshot:installbun run snapshot:installbun run snapshot:buildunzip -tintegrity checkunzip -vStorednode_modulesThe review fixes address global lifecycle/config event delivery, stale session payloads, cross-project session directories, repository-switch Git polling, ambiguous session IDs, target-specific FFmpeg cache reuse, completion-gated Git refreshes, no-Git source hashing, and reliable local VSIX storage mode.