Skip to content

fix(vscode): add project-local navigation hints - #12845

Merged
marius-kilocode merged 2 commits into
fix-multi-project-navigation-and-shortcutsfrom
agent-manager-12806-navigation
Aug 4, 2026
Merged

fix(vscode): add project-local navigation hints#12845
marius-kilocode merged 2 commits into
fix-multi-project-navigation-and-shortcutsfrom
agent-manager-12806-navigation

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Multi-project Agent Manager worktree hover cards do not show the previous/next navigation hints that are available in the single-project sidebar. The rendered project body also needs its own local sidebar order so raw worktree IDs cannot resolve against another project.

This follow-up is stacked on #12843 and adds project-scoped previous/next hints using each project's rendered sidebar order. Duplicate raw IDs remain isolated between projects without reimplementing the global keyboard navigation or shortcut work from #12843.

Previous navigation hint on a project-local worktree hover card

Next navigation hint on a project-local worktree hover card

Fixes #12806

@kilo-code-bot

kilo-code-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (5 files)
  • .changeset/project-local-navigation-hints.md
  • packages/kilo-vscode/tests/unit/project-local-navigation.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/ProjectList.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/ProjectSidebarBody.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/project-local-navigation.ts

Incremental note: the new commit aligns the hint order with the multi-project nav order by feeding an empty session list when the sessions section is collapsed (state()?.sessionsCollapsed ? [] : localSessions()), resolving the previous round's collapsed-sessions mismatch — verified against buildProjectNavOrder, which skips unassigned sessions under the same condition. The earlier hint/nav order-mismatch finding also remains resolved: the rebased base builds the nav order with the same semantics as the rendered sidebar (ungrouped rank-sorted first, then rank-sorted sections, sessions last). Reactivity is sound (props.state is tracked inside the createMemo), an undefined state is consistently treated as expanded across hint order, nav order, and the rendered section, and there are no memory-leak concerns — the change only alters a createMemo expression with no new timers, subscriptions, or listeners.

Previous Review Summaries (2 snapshots, latest commit 8fe5329)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 8fe5329)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/kilo-vscode/webview-ui/agent-manager/ProjectSidebarBody.tsx 105 Hint order always includes unassigned sessions, but the multi-project nav order skips them when the sessions section is collapsed — with a collapsed section and an unassigned session open, the last worktree's previous-session hint is a no-op
Files Reviewed (5 files)
  • .changeset/project-local-navigation-hints.md - 0 issues
  • packages/kilo-vscode/tests/unit/project-local-navigation.test.ts - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/ProjectList.tsx - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/ProjectSidebarBody.tsx - 1 issue
  • packages/kilo-vscode/webview-ui/agent-manager/project-local-navigation.ts - 0 issues

Incremental note: the previous round's hint/nav order mismatch is resolved — the rebased base (#12843) now builds the multi-project nav order with the same semantics as the rendered sidebar (ungrouped rank-sorted first, then rank-sorted sections with sortWorktrees member order). No memory-leak concerns: the change adds only a createMemo and pure functions — no new timers, subscriptions, or listeners.

Fix these issues in Kilo Cloud

Previous review (commit f8727c8)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/kilo-vscode/webview-ui/agent-manager/ProjectSidebarBody.tsx 106 Hint uses the project-local rendered order, but the active multi-project previousSession/nextSession handler (createProjectNav.stepbuildProjectNavOrder) traverses a global order with sections before ungrouped worktrees and raw (unsorted) state order — the advertised keybinding can target a different item until #12843 lands
Files Reviewed (5 files)
  • .changeset/project-local-navigation-hints.md - 0 issues
  • packages/kilo-vscode/tests/unit/project-local-navigation.test.ts - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/ProjectList.tsx - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/ProjectSidebarBody.tsx - 1 issue
  • packages/kilo-vscode/webview-ui/agent-manager/project-local-navigation.ts - 0 issues

The project-isolation guard (projectId !== activeProjectId) correctly prevents raw-ID collisions between projects, the selection ?? currentSessionID fallback matches single-project semantics, tests exercise the real implementation, and a user-facing changeset is included. No memory-leak concerns: the change adds only a createMemo and pure functions — no new timers, subscriptions, or listeners.

Fix these issues in Kilo Cloud


Reviewed by kimi-k3 · Input: 59.8K · Output: 11.5K · Cached: 593.2K

Review guidance: REVIEW.md from base branch fix-multi-project-navigation-and-shortcuts

@marius-kilocode
marius-kilocode force-pushed the agent-manager-12806-navigation branch from f8727c8 to 8fe5329 Compare August 4, 2026 09:28
@marius-kilocode
marius-kilocode changed the base branch from main to fix-multi-project-navigation-and-shortcuts August 4, 2026 09:28
Comment thread packages/kilo-vscode/webview-ui/agent-manager/ProjectSidebarBody.tsx Outdated
@marius-kilocode
marius-kilocode merged commit 41ce0ce into fix-multi-project-navigation-and-shortcuts Aug 4, 2026
21 checks passed
@marius-kilocode
marius-kilocode deleted the agent-manager-12806-navigation branch August 4, 2026 09:48
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…avigation

fix(vscode): add project-local navigation hints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Match multi-project Agent Manager worktree row parity

1 participant