feat(agent-manager): align and persist collapsible headers by marius-kilocode · Pull Request #12844 · Kilo-Org/kilocode

marius-kilocode · 2026-08-04T08:49:51Z

The Agent Manager used separate header layouts for projects, user-defined sections, and sessions. Their chevrons and labels could land in different columns, and project expansion state was not consistently restored across reopen and reload.

This change introduces a shared SidebarSectionHeader component with a fixed leading control column and reusable label, count, and action slots. Project expansion state is persisted for both catalog projects and the pinned project, then restored when project contexts initialize. Existing selection, trust, rename, context-menu, and action behavior is preserved.

Before:

After:

kilo-code-bot · 2026-08-04T09:18:40Z

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)

packages/kilo-vscode/webview-ui/agent-manager/ProjectsSection.tsx

Previous Review Summaries (3 snapshots, latest commit 43a222d)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit `43a222d`)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	1

Incremental review of 43a222d0 (1 commit since cf4a8f2f): the SidebarSearchOpen story reverts to the raw am-section-header markup, restoring the DOM structure the existing visual-regression baseline was generated against. The SidebarSectionHeader import removal is clean and no new issues were found in the changed file. The previous suggestion below was re-verified against current HEAD and remains unresolved.

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
`packages/kilo-vscode/webview-ui/agent-manager/ProjectsSection.tsx`	98	Clicking a missing project's header still fires `onExpand`; since the snapshot now masks `expanded` for missing projects, every click invisibly persists `expanded=true` and initializes a context for a nonexistent directory

Files Reviewed (2 files)

packages/kilo-vscode/webview-ui/src/stories/agent-manager.stories.tsx (incremental diff)
packages/kilo-vscode/webview-ui/agent-manager/ProjectsSection.tsx - 1 issue (carry-forward, re-verified)

Fix these issues in Kilo Cloud

Previous review (commit `cf4a8f2`)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	1

All 9 findings from the previous review are resolved in cf4a8f2f: rename commit-on-blur is restored with a re-entrancy guard, missing projects can no longer be selected via header click, the header wrapper's role="button" was replaced with a real chevron <button>, setExpanded uses a fresh post-await context, isExpanded() is now a pure read-through, initExpanded has a rejection handler, panel close disposes the per-project pollers, missing projects no longer render a perpetual spinner, and .am-section-header regained its flex layout with the story updated to match. One new minor finding below.

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
`packages/kilo-vscode/webview-ui/agent-manager/ProjectsSection.tsx`	98	Clicking a missing project's header still fires `onExpand`; since the snapshot now masks `expanded` for missing projects, every click invisibly persists `expanded=true` and initializes a context for a nonexistent directory

Files Reviewed (11 files)

packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/sidebar-search-open-chromium-linux.png (LFS baseline)
packages/kilo-vscode/src/agent-manager/AgentManagerProvider.ts
packages/kilo-vscode/src/agent-manager/project/contexts.ts
packages/kilo-vscode/src/agent-manager/project/messages.ts
packages/kilo-vscode/tests/unit/agent-project-contexts.test.ts
packages/kilo-vscode/webview-ui/agent-manager/ProjectsSection.tsx - 1 issue
packages/kilo-vscode/webview-ui/agent-manager/SectionHeader.tsx
packages/kilo-vscode/webview-ui/agent-manager/SidebarSectionHeader.tsx
packages/kilo-vscode/webview-ui/agent-manager/UnassignedSessionsSection.tsx
packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
packages/kilo-vscode/webview-ui/src/stories/agent-manager.stories.tsx

Fix these issues in Kilo Cloud

Previous review (commit `5f95cdc`)

Status: 9 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	8
SUGGESTION	1

The shared SidebarSectionHeader refactor and expansion persistence are well structured, and the registry format/cache handling is careful. The main concerns: the section rename input lost its commit-on-blur, missing projects can now be activated via header click, the new role="button" wrapper hides nested controls from assistive tech, a pre-await context is used after the registry write, isExpanded() gained a state-poisoning side effect, and the new auto-restore loop amplifies an unhandled-rejection path and a per-project poller leak after panel close.

Issue Details (click to expand)

WARNING

File	Line	Issue
`packages/kilo-vscode/webview-ui/agent-manager/SectionHeader.tsx`	86	Rename input lost `onBlur={commit}` — clicking away leaves the section stuck in rename mode
`packages/kilo-vscode/webview-ui/agent-manager/ProjectsSection.tsx`	99	Missing-but-trusted projects can now be selected/activated via header click
`packages/kilo-vscode/webview-ui/agent-manager/SidebarSectionHeader.tsx`	27	`role="button"` + `aria-label` wrapper hides nested interactive controls from assistive tech
`packages/kilo-vscode/src/agent-manager/project/messages.ts`	200	`deps.expand(ctx)` uses a context captured before the registry-write await (stale-context race)
`packages/kilo-vscode/src/agent-manager/project/contexts.ts`	144	`isExpanded()` side effect can cache `false` for the pinned project before `active()` applies its `true` fallback
`packages/kilo-vscode/src/agent-manager/AgentManagerProvider.ts`	1581	`initExpanded` promise has no rejection handler; new loop fires it automatically on every panel open
`packages/kilo-vscode/src/agent-manager/AgentManagerProvider.ts`	1576	Auto-restored projects' pollers are never stopped when the panel closes (background git polling leak)
`packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css`	246	`.am-section-header` lost flex layout; `SidebarSearchOpen` story still uses it raw and the regenerated baseline baked in the degraded layout

SUGGESTION

File	Line	Issue
`packages/kilo-vscode/src/agent-manager/AgentManagerProvider.ts`	1578	Persisted-expanded but now-missing projects render a perpetual spinner until clicked

Files Reviewed (16 files)

.changeset/persist-project-accordion.md
packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/sidebar-search-open-chromium-linux.png (LFS baseline)
packages/kilo-vscode/src/agent-manager/AgentManagerProvider.ts - 3 issues
packages/kilo-vscode/src/agent-manager/project/contexts.ts - 1 issue
packages/kilo-vscode/src/agent-manager/project/messages.ts - 1 issue
packages/kilo-vscode/src/agent-manager/project/registry.ts
packages/kilo-vscode/tests/unit/agent-manager-arch.test.ts
packages/kilo-vscode/tests/unit/agent-project-contexts.test.ts
packages/kilo-vscode/tests/unit/agent-project-messages.test.ts
packages/kilo-vscode/webview-ui/agent-manager/ProjectSidebarBody.tsx
packages/kilo-vscode/webview-ui/agent-manager/ProjectsSection.tsx - 1 issue
packages/kilo-vscode/webview-ui/agent-manager/SectionHeader.tsx - 1 issue
packages/kilo-vscode/webview-ui/agent-manager/SidebarBody.tsx
packages/kilo-vscode/webview-ui/agent-manager/SidebarSectionHeader.tsx - 1 issue
packages/kilo-vscode/webview-ui/agent-manager/UnassignedSessionsSection.tsx
packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css - 1 issue

Fix these issues in Kilo Cloud

_{Reviewed by kimi-k3 · Input: 18.2K · Output: 10K · Cached: 223.1K}

_{Review guidance: REVIEW.md from base branch main}

johnnyeric · 2026-08-04T11:21:05Z

+                  }
+                  const expanded = !project().expanded
+                  props.onExpand(project().id, expanded)
+                  if (!project().active && project().trusted && !project().missing) props.onSelect(project().id)


With this wiring, it seems that an expanded inactive project gets collapsed when being selected. Worth checking.

Thats actually the point of the PR. Selection itself on project level does't fully make sense. Therefore a click on the project header in multi project mode will expand the project.

Previously it only expanded when clicking on the little icon.

Got it, thanks for the explanation

…header-collapse-persistence feat(agent-manager): align and persist collapsible headers

feat(agent-manager): align and persist collapsible headers

245ada5

kilo-code-bot Bot reviewed Aug 4, 2026

View reviewed changes

fix(agent-manager): address review findings

cf4a8f2

marius-kilocode force-pushed the toggle-multi-project-header-collapse-persistence branch from 5f95cdc to cf4a8f2 Compare August 4, 2026 09:35

kilo-code-bot Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread packages/kilo-vscode/webview-ui/agent-manager/ProjectsSection.tsx

marius-kilocode added 2 commits August 4, 2026 11:48

fix(agent-manager): preserve search story structure

43a222d

fix(agent-manager): ignore missing project toggles

aaa2a8f

marius-kilocode enabled auto-merge August 4, 2026 10:06

johnnyeric reviewed Aug 4, 2026

View reviewed changes

johnnyeric approved these changes Aug 4, 2026

View reviewed changes

merge: resolve main conflicts for project accordion

6430600

marius-kilocode merged commit 5117a9f into main Aug 4, 2026
23 checks passed

marius-kilocode deleted the toggle-multi-project-header-collapse-persistence branch August 4, 2026 12:53

github-actions Bot mentioned this pull request Aug 5, 2026

docs: auto-sync with merged PRs (through 2026-08-05) #12835

Merged

This was referenced Aug 5, 2026

release(jetbrains): v7.0.13-rc.1 #12919

Merged

release(jetbrains): v7.0.13 #12921

Merged

t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026

Merge pull request Kilo-Org#12844 from Kilo-Org/toggle-multi-project-…

3150882

…header-collapse-persistence feat(agent-manager): align and persist collapsible headers

Uh oh!

Conversation

marius-kilocode commented Aug 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kilo-code-bot Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Previous review (commit 43a222d)

Overview

SUGGESTION

Previous review (commit cf4a8f2)

Overview

SUGGESTION

Previous review (commit 5f95cdc)

Overview

WARNING

SUGGESTION

Uh oh!

Uh oh!

johnnyeric Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

marius-kilocode Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

marius-kilocode Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

johnnyeric Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kilo-code-bot Bot commented Aug 4, 2026 •

edited

Loading

Previous review (commit `43a222d`)

Previous review (commit `cf4a8f2`)

Previous review (commit `5f95cdc`)