fix(vscode): surface macOS speech capture errors - #12821
Conversation
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Previous Review Summary (commit fea1393)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit fea1393)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by kimi-k3 · Input: 43.8K · Output: 7.2K · Cached: 334.6K Review guidance: REVIEW.md from base branch |
fea1393 to
661c094
Compare
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| if (!recorder || !recorder.prepareToRecord || !recorder.record) throw new Error("Could not start recording") | ||
| if (!recorder || !recorder.prepareToRecord || !recorder.record) { | ||
| const description = error[0] && error[0].localizedDescription | ||
| throw new Error(description ? description.js : "Could not start recording") |
There was a problem hiding this comment.
SUGGESTION: Missing changeset for a user-facing diagnostics change
This PR changes the error text users see when native macOS speech capture fails to start, which is user-visible behavior in the VS Code extension. Per the repo's changeset guidance, user-facing fixes should ship with a .changeset/*.md entry (e.g. a patch bump for kilo-code) so the improvement shows up in release notes.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
There was a problem hiding this comment.
fine for now
…diagnostics fix(vscode): surface macOS speech capture errors
2 participants
Follow-up to #12814. The native macOS speech bridge already captures an NSError when AVAudioRecorder initialization fails, but discarded it and reported only a generic startup error.
Include the NSError localized description when available, while retaining the generic fallback when macOS does not populate the reference. This makes microphone permission, device, and format failures actionable in the existing speech-capture diagnostics without changing the recording lifecycle.