Skip to content

test(cli): isolate PTY route tests from indexing - #12818

Merged
marius-kilocode merged 2 commits into
mainfrom
fix-cli-ci-tests
Aug 4, 2026
Merged

test(cli): isolate PTY route tests from indexing#12818
marius-kilocode merged 2 commits into
mainfrom
fix-cli-ci-tests

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

The Darwin CLI profile runs these PTY route tests with full instance bootstrap. Each temporary project inherits Kilo's default indexing plugin, which fork-detaches indexing startup and can race PTY setup or consume native test resources. In the failing run, indexing initialization appeared immediately before the plugin-backed PTY test stalled.\n\nDisable codebase indexing for this test file, matching the existing instance-route auth test isolation. The suite still exercises external plugin loading, PTY environment precedence, credential stripping, websocket output, and cleanup, but no longer starts an unrelated indexing worker for each temporary project. The test retains its original 30-second deadline.

@kilo-code-bot

kilo-code-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

lgtm — incremental review of the follow-up commit. The PTY test file now sets KILO_DISABLE_CODEBASE_INDEXING = "vscode-no-workspace" at module scope (properly wrapped in kilocode_change markers), which src/kilocode/indexing.ts:278 reads lazily at per-instance boot, so the assignment is effective before any temp project spins up. This matches the established isolation pattern in test/server/httpapi-exercise/environment.ts. The test timeout reverts to its original 30_000 positional argument (valid for effectIt.live), consistent with the updated PR description, and the strict inner 5-second output wait in takeUntil still fails fast on genuinely missing PTY output.

Files Reviewed (1 file)
  • packages/opencode/test/server/httpapi-v2-pty.test.ts
Previous Review Summary (commit 48400d8)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 48400d8)

Status: No Issues Found | Recommendation: Merge

lgtm — single-line test-only timeout bump (30_00060_000) for the plugin-backed PTY integration test. Verified the positional timeout argument is valid for effectIt.live (opts?: number | TestOptions passed through to bun:test), the kilocode_change marker is retained, and the updated comment accurately reflects the rationale (Darwin CI contention). The strict inner 5-second output wait is preserved, so the test still fails fast on genuinely missing PTY output.

Files Reviewed (1 file)
  • packages/opencode/test/server/httpapi-v2-pty.test.ts

Reviewed by kimi-k3 · Input: 39K · Output: 4.3K · Cached: 261.1K

Review guidance: REVIEW.md from base branch main

@marius-kilocode marius-kilocode changed the title test(cli): allow PTY plugin test more startup time test(cli): isolate PTY route tests from indexing Aug 3, 2026
@marius-kilocode
marius-kilocode enabled auto-merge (squash) August 3, 2026 16:42
@marius-kilocode
marius-kilocode merged commit 41c19ee into main Aug 4, 2026
29 checks passed
@marius-kilocode
marius-kilocode deleted the fix-cli-ci-tests branch August 4, 2026 12:53
LudwigSolutionsAI pushed a commit to LudwigSolutionsAI/kilocode that referenced this pull request Aug 6, 2026
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
test(cli): isolate PTY route tests from indexing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants