Skip to content

fix(agent-manager): make worktree hover cards instant - #12799

Merged
marius-kilocode merged 2 commits into
mainfrom
fix-worktree-tooltip-delay
Aug 3, 2026
Merged

fix(agent-manager): make worktree hover cards instant#12799
marius-kilocode merged 2 commits into
mainfrom
fix-worktree-tooltip-delay

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

Worktree hover cards regressed to delayed open and close behavior after the prior speed-up fix. Restore zero-delay open and close behavior and remove the scoped worktree-card animations so hover details respond immediately again. The change is limited to Agent Manager worktree hover cards and includes a patch changeset.

Comment thread packages/kilo-vscode/webview-ui/agent-manager/WorktreeItem.tsx
Comment thread packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css Outdated
@kilo-code-bot

kilo-code-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Optional follow-up, not blocking

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/kilo-vscode/webview-ui/agent-manager/WorktreeItem.tsx 191 closeDelay={0} leaves no tolerance for crossing the 8px gutter to reach the card's interactive controls; consider a small closeDelay with instant open
Files Reviewed (1 file changed since last review)
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css - 0 issues (previous zero-duration animation suggestion is resolved: both [data-expanded] and [data-closed] now use animation: none, which lets Kobalte's presence unmount synchronously instead of waiting on an animationend that may never fire)

Notes / assumptions

  • Incremental review of 7cfaeb2..6b5a605. Only agent-manager.css changed; the two animation: none overrides keep the same specificity as the base [data-component="hover-card-content"][data-closed] rule in packages/ui/src/components/hover-card.css and still win because agent-manager.css is bundled after @kilocode/kilo-ui/styles.
  • The closeDelay suggestion on WorktreeItem.tsx:191 is unchanged in this push and remains open as an optional follow-up.
  • No memory-leak or lifecycle concerns: CSS-only change, no new timers, listeners, or subscriptions.

Fix these issues in Kilo Cloud

Previous Review Summary (commit 7cfaeb2)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 7cfaeb2)

Status: 2 Issues Found | Recommendation: Optional follow-ups, not blocking

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 2
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/kilo-vscode/webview-ui/agent-manager/WorktreeItem.tsx 191 closeDelay={0} leaves no tolerance for crossing the 8px gutter to reach the card's PR link and Remove-stale button; consider closeDelay={50} with instant open
packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css 3290 Prefer animation: none over animation-duration: 0ms so Kobalte's presence unmount doesn't depend on a zero-duration animationend (stuck-card risk)
Files Reviewed (3 files)
  • .changeset/instant-worktree-hover.md - 0 issues (user-facing wording looks good)
  • packages/kilo-vscode/webview-ui/agent-manager/WorktreeItem.tsx - 1 issue
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css - 1 issue

Notes / assumptions

  • The PR description says the cards "regressed to delayed open and close behavior after the prior speed-up fix" and that this restores zero-delay behavior. History shows the delays went 100ms (a8d5af4) -> 50ms (909ec73) -> 0ms here, so this is a new behavior rather than a restoration; the description could be corrected. It also says the scoped animations were removed, but they are zeroed rather than removed.
  • @kobalte/core is not installed in this environment, so the hover-card safe-area and presence-unmount behavior could not be verified directly; both suggestions are reasoned from the Kobalte 0.13.x hover-card/presence design and the shared styles in packages/ui/src/components/hover-card.css.
  • Change is UI-behavior only; no memory-leak or lifecycle concerns introduced (no new timers, listeners, or subscriptions).

Fix these issues in Kilo Cloud


Reviewed by claude-opus-5 · Input: 30 · Output: 5.4K · Cached: 582.6K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 6693f2d into main Aug 3, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the fix-worktree-tooltip-delay branch August 3, 2026 10:29
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…delay

fix(agent-manager): make worktree hover cards instant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants