-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Memory Audit Diagnostics via DEBUG Log Stream #12767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rusak47
wants to merge
5
commits into
Kilo-Org:main
Choose a base branch
from
rusak47:pr/memory-audit-log
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2dc4e78
feat(kilo-memory): route memory audit diagnostics through the DEBUG l…
85a489f
Merge branch 'Kilo-Org:main' into pr/memory-audit-log
rusak47 2d64473
Merge branch 'Kilo-Org:main' into pr/memory-audit-log
rusak47 0b548f9
Update packages/kilo-memory/src/effect/capture.ts
rusak47 3ef4b70
Merge branch 'Kilo-Org:main' into pr/memory-audit-log
rusak47 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@kilocode/kilo-memory": patch | ||
| "@kilocode/cli": patch | ||
| --- | ||
|
|
||
| Log memory parse failures (including the full model output) and capture-decision records at DEBUG level. Visible by default in source/dev runs; in release builds set `KILO_LOG_LEVEL=DEBUG` or pass `--logLevel DEBUG`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import { MemoryAudit } from "../src/storage/audit" | ||
| import { MemoryLog } from "../src/effect/log" | ||
|
|
||
| describe("memory audit → debug log", () => { | ||
| let captured: { message: string; meta?: Record<string, unknown> }[] = [] | ||
|
|
||
| beforeEach(() => { | ||
| captured = [] | ||
| MemoryLog.setDebug((message, meta) => captured.push({ message, meta })) | ||
| }) | ||
|
|
||
| afterEach(() => { | ||
| MemoryLog.setDebug(() => {}) | ||
| }) | ||
|
|
||
| test("debug() is a no-op until a logger is injected", () => { | ||
|
rusak47 marked this conversation as resolved.
|
||
| MemoryLog.setDebug(() => {}) | ||
| expect(() => MemoryLog.debug("anything")).not.toThrow() | ||
| }) | ||
|
|
||
| test("append() routes a log record through the debug channel", async () => { | ||
| await MemoryAudit.append("/tmp/root", "hello world") | ||
| expect(captured).toEqual([ | ||
| { message: "memory audit", meta: { kind: "log", result: "logged", summary: "hello world" } }, | ||
| ]) | ||
| }) | ||
|
|
||
| test("decide() routes a structured decision through the debug channel", async () => { | ||
| await MemoryAudit.decide("/tmp/root", { kind: "digest", result: "saved", operationCount: 3 }) | ||
| expect(captured).toHaveLength(1) | ||
| expect(captured[0].message).toBe("memory audit") | ||
| expect(captured[0].meta).toMatchObject({ kind: "digest", result: "saved", operationCount: 3 }) | ||
| }) | ||
|
|
||
| test("warn and debug use independent channels", () => { | ||
| const warns: string[] = [] | ||
| MemoryLog.setWarn((message) => warns.push(message)) | ||
|
rusak47 marked this conversation as resolved.
|
||
| MemoryLog.warn("w1") | ||
| MemoryLog.debug("d1") | ||
| expect(warns).toEqual(["w1"]) | ||
| expect(captured.map((item) => item.message)).toEqual(["d1"]) | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.