fix(cli): handle missing nested config unsets - #12727
Conversation
Code Review SummaryStatus: 1 Issue Found | Recommendation: Optional follow-up Overview
Incremental review of Issue Details (click to expand)SUGGESTION
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Previous Review Summary (commit 5ae91eb)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 5ae91eb)Status: 2 Issues Found | Recommendation: Address before merge Overview
The fix itself looks correct: the Issue Details (click to expand)SUGGESTION
Files Reviewed (3 files)
Reviewed by claude-opus-5 · Input: 32 · Output: 4.8K · Cached: 710.2K Review guidance: REVIEW.md from base branch |
* fix(cli): handle missing nested config unsets * test(cli): cover nested config unset behavior
The VS Code Settings overlay can represent clearing a nested setting as an unset path, such as
agent.explore.model. When the project config target does not exist, the overlay writer patches an empty JSON document. jsonc-parser rejects deleting a nested path whose parent is absent withCan not delete in empty document, which surfaces in the extension as an opaqueUnexpected server error.Apply the same absent-path guard already used by the regular config writer to the overlay writer. Missing delete paths are treated as already unset, while existing paths continue to be removed normally. Add a route regression test for the missing nested project target and include a CLI patch changeset.