Skip to content

refactor(vscode): share webview provider shell - #12648

Merged
marius-kilocode merged 1 commit into
mainfrom
refactor-vscode-provider-shell
Jul 29, 2026
Merged

refactor(vscode): share webview provider shell#12648
marius-kilocode merged 1 commit into
mainfrom
refactor-vscode-provider-shell

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

The sidebar and Agent Manager each composed nearly identical provider trees. Maintaining both copies allowed a shared chat dependency to be added to one surface while leaving the other with a blank webview.

This consolidates the common provider composition into fixed provider-shell stages at the existing surface-specific cut points. The sidebar continues to own WorkStyleProvider and LocalTabsProvider, Agent Manager continues to own WorktreeModeProvider, and DataBridge stays in each root. The fixed stages preserve provider order without introducing optional provider flags or a configurable mega-component.

Architecture guards now assert the shared shell and required surface composition directly, while the existing DataBridge reactivity guards remain unchanged.

@marius-kilocode
marius-kilocode enabled auto-merge (squash) July 29, 2026 12:39
@kilo-code-bot

kilo-code-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • packages/kilo-vscode/tests/unit/agent-manager-arch.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/AgentManagerApp.tsx
  • packages/kilo-vscode/webview-ui/src/App.tsx
  • packages/kilo-vscode/webview-ui/src/context/provider-shell.tsx

Reviewed by claude-sonnet-5 · Input: 12 · Output: 4.2K · Cached: 238.5K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit efe3f62 into main Jul 29, 2026
23 checks passed
@marius-kilocode
marius-kilocode deleted the refactor-vscode-provider-shell branch July 29, 2026 12:45
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants