refactor(vscode): share webview provider shell - #12648
Merged
Merged
Conversation
marius-kilocode
enabled auto-merge (squash)
July 29, 2026 12:39
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by claude-sonnet-5 · Input: 12 · Output: 4.2K · Cached: 238.5K Review guidance: REVIEW.md from base branch |
johnnyeric
approved these changes
Jul 29, 2026
This was referenced Jul 31, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar and Agent Manager each composed nearly identical provider trees. Maintaining both copies allowed a shared chat dependency to be added to one surface while leaving the other with a blank webview.
This consolidates the common provider composition into fixed provider-shell stages at the existing surface-specific cut points. The sidebar continues to own
WorkStyleProviderandLocalTabsProvider, Agent Manager continues to ownWorktreeModeProvider, andDataBridgestays in each root. The fixed stages preserve provider order without introducing optional provider flags or a configurable mega-component.Architecture guards now assert the shared shell and required surface composition directly, while the existing DataBridge reactivity guards remain unchanged.