fix(cli): promote stable releases to rc - #12647
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| exists: () => published(name, version), | ||
| }) | ||
| } | ||
| for (const tag of NpmPublish.aliases(Script.channel)) await $`npm dist-tag add ${name}@${version} ${tag}` |
There was a problem hiding this comment.
WARNING: New npm dist-tag add call has no retry/error handling, unlike the publish path it follows
NpmPublish.retry exists specifically to tolerate transient npm publish failures, but this new npm dist-tag add ${name}@${version} ${tag} call has none. If it fails transiently (network blip, registry hiccup), the whole publish() promise rejects even though the package itself published successfully, and the rc alias won't be advanced -- which is exactly the reliability problem this PR is meant to fix. Consider running this through NpmPublish.retry (or at least wrapping it so a transient dist-tag failure doesn't fail the whole release) for parity with the publish step above.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (4 files)
Fix these issues in Kilo Cloud Reviewed by claude-sonnet-5 · Input: 24 · Output: 8.5K · Cached: 654.3K Review guidance: REVIEW.md from base branch |
2 participants
CLI installations built from the
rcchannel resolve upgrades through npm’srcdist-tag. Stable publishes currently update onlylatest, which can leave RC users pinned to an older release even after a newer stable version is available.Stable CLI publishes now also advance the
rcalias after publishing, including idempotent workflow reruns where the package version already exists. Prerelease publishes continue to update only their own channel, so stable users remain isolated from prerelease releases.