feat(agent-manager): add embedded side-panel terminal destination - #12598
Merged
Conversation
The Agent Manager terminal button and Focus Terminal shortcut can now open a terminal in the right-hand inspector next to the diff panel instead of the VS Code integrated terminal. A split-button dropdown on the toolbar picks the destination and persists it as the kilo-code.new.agentManager.terminalButtonDestination setting (default: vscode, preserving existing behavior). The side terminal shares the existing inspector host with the diff view, keeps running while hidden, toggles via the same button or shortcut, and hands focus back to the chat composer when minimized. Each context (worktree or local) gets one reusable side terminal with its own remembered panel width.
…name kilo-ui's IconButton forwards label as an inert HTML attribute rather than an accessible name, so the header action failed the WCAG button-name check in the visual regression accessibility run. Use aria-label, which Kobalte forwards to the button element.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (2 files)
This incremental review only covers the diff since the last review pass. No new code changes were introduced — the only change is the removal of two internal planning docs under Fix these issues in Kilo Cloud Previous Review Summary (commit d9289e1)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit d9289e1)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (49 files)
Reviewed by claude-sonnet-5 · Input: 30 · Output: 7.9K · Cached: 652.2K Review guidance: REVIEW.md from base branch |
johnnyeric
approved these changes
Jul 28, 2026
This was referenced Jul 29, 2026
This was referenced Jul 31, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
…ebar-integration feat(agent-manager): add embedded side-panel terminal destination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent Manager's terminal button and the Focus Terminal shortcut always opened the VS Code integrated terminal at the bottom of the window. Users who live in the Agent Manager had to leave its layout to use a shell, and the bottom panel fights the chat for vertical space.
This adds a second destination for that action: an embedded terminal in the right-hand inspector that already hosts the diff view. The terminal button becomes a split button whose dropdown picks between
VS Code terminal(default, unchanged behavior) andAgent Manager panel, persisted as thekilo-code.new.agentManager.terminalButtonDestinationsetting so the choice survives reloads.How it behaves:
Cmd/Ctrl+/toggle the panel like the diff toggle. Hiding keeps the PTY alive; the xterm instance stays mounted at zero opacity so scrollback and running processes survive, and the same instance is reused per context (worktree or local).placement(tabvsside) end to end, so side terminals stay out of the tab strip, tab order, and session replacement logic. Side-terminal creates are correlated with acreateId(deliberately not the genericrequestIdchannel) so a create that lands after the user closed the panel or switched context is closed instead of leaked. Tab creates keep their existing create-and-navigate behavior.Scope: one side terminal per context. Follow-ups are tracked separately: per-worktree session terminals following the same destination (#12595) and multiple terminals per panel (#12597).