fix: make snapshot diffs resilient on Windows - #12583
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Reviewed by claude-sonnet-5 · Input: 32 · Output: 8.7K · Cached: 792.9K Review guidance: REVIEW.md from base branch |
marius-kilocode
left a comment
There was a problem hiding this comment.
Thanks for the fix! Verified end to end: new snapshots persist bounded hunks, and with a deliberately corrupted patch in session_diff storage the Changes panel keeps the file listed with its stats as a summarized entry instead of emptying to 0 files changed. Both layers do exactly what the description says. Nice work.
|
Hi! I'm noobezlol. I have 3 merged PRs and 6 open PRs. I think I qualify for the Contributor role, but I only see the inactive #kilo-dev-contributors channel. Is there another contributor channel or someone who can grant access? Thanks! |
Issue
Fixes #12474
Context
Snapshot generation requested effectively unlimited unified-diff context. On Windows, Git can emit malformed persisted patches for multi-hunk changes. The VS Code session diff source also allowed one parser exception to abort the complete diff response, leaving the Changes panel at
0 files changedeven when other file patches were valid.Implementation
--unified=3context.Screenshots / Video
N/A — this changes snapshot generation and error recovery behavior without changing the UI layout.
How to Test
Manual/local verification
git diff --checkpassed.Reviewer test steps
Blocked checks and substitute verification
/usr/lib/jvm/java-25-openjdkinstallation does not provideJAVA_COMPILER. This PR does not touch JetBrains code; the affected CLI and VS Code typechecks and targeted regression suites passed.Checklist
Get in Touch
GitHub: @noobezlol