Skip to content

fix(jetbrains): avoid writing release signing secrets - #12575

Merged
kirillk merged 1 commit into
mainfrom
fix/jetbrains-release-signing-raw-secrets
Jul 27, 2026
Merged

fix(jetbrains): avoid writing release signing secrets#12575
kirillk merged 1 commit into
mainfrom
fix/jetbrains-release-signing-raw-secrets

Conversation

@kirillk

@kirillk kirillk commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Restore raw-content JetBrains signing inputs for CI so release workflows do not write signing secrets to temp files.
  • Keep file-path signing inputs for local release builds that already use pre-existing secret files.
  • Run the bundled signing, signature verification, and plugin verification in one Gradle invocation with an explicit verifyPluginSignature -> signPlugin dependency.

Context

The bundled release failure started as a Gradle 9 implicit dependency error between verifyPluginSignature and signPlugin. Splitting those tasks into separate invocations avoided that error but exposed raw multiline PEM handling in zip-signer, leading to temp-file secret writes. This fixes the original task dependency directly and keeps the Marketplace publish path on the historically working raw-secret publishPlugin flow.

@kilo-code-bot

kilo-code-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • .github/workflows/publish-jetbrains-bundled.yml
  • packages/kilo-jetbrains/build.gradle.kts

Reviewed by claude-sonnet-5 · Input: 30 · Output: 9.3K · Cached: 974.5K

Review guidance: REVIEW.md from base branch main

@kirillk
kirillk merged commit d333877 into main Jul 27, 2026
29 checks passed
@kirillk
kirillk deleted the fix/jetbrains-release-signing-raw-secrets branch July 27, 2026 19:39
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…-signing-raw-secrets

fix(jetbrains): avoid writing release signing secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants