fix(ui): preserve parenthesized tildes in markdown - #12540
Merged
johnnyeric merged 2 commits intoJul 27, 2026
Merged
Conversation
Githubguy132010
marked this pull request as ready for review
July 26, 2026 14:36
johnnyeric
approved these changes
Jul 27, 2026
Contributor
|
Thanks for the fix! Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #12530
Context
Marked treats a tilde immediately preceded by
(as a closing strikethrough delimiter. As a result, ordinary expressions such as(~24 GB)and(~5.7 GB)can form an unintended strikethrough span in rendered chat messages.Implementation
Reject the invalid closing delimiter at the existing Marked tokenizer boundary while preserving valid single- and double-tilde strikethrough syntax. Regression coverage includes the minimal issue reproduction, the reported size example, tilde paths, and valid strikethrough forms.
Screenshots / Video
Before:
After:
How to Test
Manual/local verification
@opencode-ai/uitest suite: 90 passed, 0 failed.git diff --check; all passed.Reviewer test steps
(~a (~bor(~24 GB) and (~5.7 GB)in a chat message.~removed~,~~removed~~, and(~removed~).removed.Blocked checks and substitute verification
Checklist
Get in Touch
thomas07374