Repository navigation
fix(vscode): enforce unfiltered webview typechecks #12402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1a22a59
fix(vscode): stop filtering typecheck errors
chrarnoldus 9b0b0a3
fix(vscode): stop filtering typecheck errors
chrarnoldus 668fbf6
fix(vscode): stop filtering typecheck errors
chrarnoldus 00c7d73
fix(vscode): stop filtering typecheck errors
chrarnoldus 6aca958
fix(vscode): stop filtering typecheck errors
chrarnoldus 5cb0382
Merge latest main into typecheck improvements
chrarnoldus 00c5da3
fix(ui): surface invalid diff inputs
chrarnoldus 39a09ff
fix(ui): keep diff narrowing type-only
chrarnoldus f21793a
Merge branch 'main' into fix/vscode-unfiltered-typecheck
chrarnoldus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| declare module "*.svg" { | ||
| const src: string | ||
| export default src | ||
| } | ||
|
|
||
| declare module "*?worker&url" { | ||
| const src: string | ||
| export default src | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUGGESTION: Silent no-op guard skips downstream render-completion work
When
metadatais falsy this branch is only reachable for theDiffPairvariant, wherebefore/afterare required (non-optional) at the type level -- theundefinedonly shows up becauselocalmerges both union members. So this guard should never actually trigger at runtime given valid props, but if it ever does (e.g. a caller bug that supplies neitherfileDiffnorbefore/after), the effect now returns beforeapplyScheme(),patchSeparatorLayout(),setRendered(...), andnotifyRendered()run -- silently leaving the diff view in a "stuck" state (e.g.onRenderednever firing) with no error surfaced. Consider a dev-time warning/invariant here instead of a bare early return, so a misuse is visible rather than manifesting as a UI that never finishes "rendering".Reply with
@kilocode-bot fix itto have Kilo Code address this issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 00c5da3. The narrowing guard now throws a descriptive invariant error when
fileDiffis absent without validbefore/afterinputs, so malformed props surface immediately instead of silently skipping render-completion work. Direct extension/webview typecheck, lint, and formatting pass.