feat(agent-manager): effort selection in compare models, fix worktree prompt scrollbars - #12401
Conversation
… prompt scrollbars
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| // next input re-fits the height. | ||
| box.style.height = "auto" | ||
| const chrome = box.offsetHeight - area.offsetHeight | ||
| box.style.height = `${Math.min(area.scrollHeight, 200) + chrome}px` |
There was a problem hiding this comment.
WARNING: Manual container resize is wiped on every keystroke
adjustHeight() runs on every input/paste/undo/speech-insert event and unconditionally sets box.style.height = "auto" before recomputing from scrollHeight. Since .am-nv-dialog .am-prompt-input-container has resize: vertical, a user who manually drags the container taller sets an inline height on this same element — which gets discarded the moment they type another character, snapping the box back to the content-fit size. This contradicts the PR's own claim (changeset + comment above) that "manual resize of the prompt area keeps working." Consider tracking whether the user has manually resized (e.g. via a flag set on mousedown/native resize observation) and skipping the auto-grow recompute in that case, similar to how some editors distinguish user-driven resize from content-driven auto-grow.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| } | ||
|
|
||
| .am-mm-variant-select { | ||
| max-width: 110px; |
There was a problem hiding this comment.
SUGGESTION: text-overflow: ellipsis has no effect without overflow: hidden and white-space: nowrap
.am-mm-variant-select only sets max-width: 110px and text-overflow: ellipsis. Without overflow: hidden; white-space: nowrap;, the browser won't actually truncate long effort labels with an ellipsis — the <select> will just render at its natural width or wrap.
| max-width: 110px; | |
| .am-mm-variant-select { | |
| max-width: 110px; | |
| overflow: hidden; | |
| white-space: nowrap; | |
| text-overflow: ellipsis; | |
| } |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
The backend/model-allocation logic ( Files Reviewed (29 files)
Fix these issues in Kilo Cloud Reviewed by claude-sonnet-5 · Input: 52 · Output: 18.5K · Cached: 1.9M Review guidance: REVIEW.md from base branch |
feat(agent-manager): effort selection in compare models, fix worktree prompt scrollbars
2 participants
Fixes #12377.
The new-worktree dialog's prompt field could show two nested scrollbars at once: the wrapper around the textarea scrolled (overflow-y: auto) while the textarea itself also scrolled once its JS-driven height hit the 200px cap, with min-height: 100% forcing the wrapper to overflow even for modest content. The prompt area now follows the same model as the sidebar chat input: the container is the only element that changes size (auto-grow capped at 200px of text, manual bottom-edge resize preserved), and the textarea fills it and is the only element that scrolls. The dialog is also wider (512px to 640px) so longer prompts stay readable.
The issue also asks for effort selection in the model comparison window. Compare Models never had per-model reasoning effort: the selector row is hidden in compare mode and allocations only carried a count. Checked models that declare reasoning variants now get an effort dropdown next to the count dropdown, and the picked effort is threaded through modelAllocations into each created session's initial message. A per-model pick wins over the dialog-level variant, and the collapsed selector summarizes it, e.g. "Claude Opus 4.8 (high)". Models without variants behave as before.