fix(cli): repair cloud session imports - #12329
Conversation
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
New in this update (commit `5255b4446d`)
Files Reviewed (13 files)
Fix these issues in Kilo Cloud Previous Review Summaries (2 snapshots, latest commit 11b673e)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 11b673e)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Resolved since last review
Files Reviewed (2 files changed since last review)
Fix these issues in Kilo Cloud Previous review (commit 7c35a20)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (12 files)
Reviewed by claude-sonnet-5 · Input: 42 · Output: 14.5K · Cached: 1.2M Review guidance: REVIEW.md from base branch |
|
@eshurakov kilo-gateway already depends on Zod and uses safeParse() elsewhere. Would it not make sense to use that instead of adding 18 throws? |
|
@marius-kilocode I've fixed it |
…port The plugin runs the CLI release pinned in package.json (was 7.4.11), which contains the pre-fix cloud-import path that returns HTTP 400 BadRequest in compiled builds. The fix (#12329) first ships in CLI v7.4.13. No stable release contains it yet (7.4.14 is a draft with no assets), so pin to the v7.4.13 pre-release; the automated jetbrains-cli-pin-bump PR will move to a stable release >= 7.4.13 later. kilo.cli.pinned stays true.
* fix(cli): repair cloud session imports * chore: address cloud import review feedback * refactor(gateway): validate cloud session imports with zod
…port The plugin runs the CLI release pinned in package.json (was 7.4.11), which contains the pre-fix cloud-import path that returns HTTP 400 BadRequest in compiled builds. The fix (Kilo-Org#12329) first ships in CLI v7.4.13. No stable release contains it yet (7.4.14 is a draft with no assets), so pin to the v7.4.13 pre-release; the automated jetbrains-cli-pin-bump PR will move to a stable release >= 7.4.13 later. kilo.cli.pinned stays true.
Summary
Why
The Effect handler crossed into the legacy database client. Native binaries then attempted to read migrations from
/$bunfs/migration, while source runs could insert the session twice through the legacy transaction and EventV2 projector. Keeping one persistence owner removes both failure modes and prevents partially imported transcripts or filesystem changes.