fix: allow ES2023 library APIs - #12294
Merged
Merged
Conversation
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Simple, scoped Files Reviewed (5 files)
Reviewed by claude-sonnet-5 · Input: 12 · Output: 2.3K · Cached: 203.6K Review guidance: REVIEW.md from base branch |
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
marius-kilocode
approved these changes
Jul 20, 2026
johnnyeric
approved these changes
Jul 20, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
fix: allow ES2023 library APIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Use ES2023 standard-library definitions for the VS Code extension host and webview, SDK, plugin, and Atomic Chat plugin while retaining their existing emitted syntax targets.
Why
The extension directly imports Kilo Gateway code for two extension-owned features:
@kilocode/kilo-gateway/autocompletesubpath@kilocode/kilo-gatewayexportThe root import causes TypeScript to resolve the gateway barrel and its re-export graph, including
gateway-metadata.ts, under the extension tsconfig. That exposed the stale ES2022 library definition when the gateway implementation usedArray.findLast.VS Code and Cursor compatibility
The extension deliberately supports VS Code
^1.105.1for Cursor compatibility. VS Code 1.105.1 embeds Node 22.19 and Chromium 138; both support ES2023 APIs, includingArray.findLast. Cursor versions compatible with this VS Code extension API baseline use a sufficiently modern Chromium/Node runtime as well. Raisinglibtherefore changes TypeScript standard-library declarations without raising the extension engine requirement.The existing
target: ES2022values remain unchanged, so emitted syntax compatibility is unaffected.The SDK and plugin packages extend the Node 22 tsconfig, and Atomic Chat runs through that plugin runtime, so their ES2023 library declarations match their runtime floor.
This branch is based on main at
9ac93a4c90, including #12289.