Skip to content

fix: allow ES2023 library APIs - #12294

Merged
chrarnoldus merged 2 commits into
mainfrom
fix/es2023-libs
Jul 20, 2026
Merged

fix: allow ES2023 library APIs#12294
chrarnoldus merged 2 commits into
mainfrom
fix/es2023-libs

Conversation

@chrarnoldus

@chrarnoldus chrarnoldus commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

What changed

Use ES2023 standard-library definitions for the VS Code extension host and webview, SDK, plugin, and Atomic Chat plugin while retaining their existing emitted syntax targets.

Why

The extension directly imports Kilo Gateway code for two extension-owned features:

  • the browser-safe autocomplete model catalog through the dedicated @kilocode/kilo-gateway/autocomplete subpath
  • the embedding model catalog fetcher used by indexing settings through the root @kilocode/kilo-gateway export

The root import causes TypeScript to resolve the gateway barrel and its re-export graph, including gateway-metadata.ts, under the extension tsconfig. That exposed the stale ES2022 library definition when the gateway implementation used Array.findLast.

VS Code and Cursor compatibility

The extension deliberately supports VS Code ^1.105.1 for Cursor compatibility. VS Code 1.105.1 embeds Node 22.19 and Chromium 138; both support ES2023 APIs, including Array.findLast. Cursor versions compatible with this VS Code extension API baseline use a sufficiently modern Chromium/Node runtime as well. Raising lib therefore changes TypeScript standard-library declarations without raising the extension engine requirement.

The existing target: ES2022 values remain unchanged, so emitted syntax compatibility is unaffected.

The SDK and plugin packages extend the Node 22 tsconfig, and Atomic Chat runs through that plugin runtime, so their ES2023 library declarations match their runtime floor.

This branch is based on main at 9ac93a4c90, including #12289.

Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@chrarnoldus chrarnoldus self-assigned this Jul 16, 2026
@kilo-code-bot

kilo-code-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Simple, scoped lib bump (ES2022 → ES2023) across 5 tsconfig files, keeping target unchanged. Matches the stated rationale (Node 22 / VS Code 1.105.1 runtime support) and doesn't touch shared opencode source logic.

Files Reviewed (5 files)
  • packages/kilo-vscode/tsconfig.json
  • packages/kilo-vscode/webview-ui/tsconfig.json
  • packages/plugin-atomic-chat/tsconfig.json
  • packages/plugin/tsconfig.json
  • packages/sdk/js/tsconfig.json

Reviewed by claude-sonnet-5 · Input: 12 · Output: 2.3K · Cached: 203.6K

Review guidance: REVIEW.md from base branch main

Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@chrarnoldus
chrarnoldus merged commit d237196 into main Jul 20, 2026
28 checks passed
@chrarnoldus
chrarnoldus deleted the fix/es2023-libs branch July 20, 2026 09:23
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants