Skip to content

fix(agent-manager): open worktree dialog by default - #12279

Merged
marius-kilocode merged 2 commits into
mainfrom
change-agent-manager-plus-default
Jul 17, 2026
Merged

fix(agent-manager): open worktree dialog by default#12279
marius-kilocode merged 2 commits into
mainfrom
change-agent-manager-plus-default

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

Creating a worktree from the primary Agent Manager action immediately changed repository state without letting people select the branch, prompt, model, mode, sandbox, or multi-version options now available in the worktree dialog. The shortcut and tooltip affordances also no longer communicated one consistent behavior.\n\nThe primary add action and Cmd/Ctrl+N now open the New Worktree dialog. Cmd/Ctrl+Shift+N remains the explicit quick-create path from the default base branch, including the restored dropdown hint. Command Palette labels, in-product shortcut help, tooltips, localization, and documentation use the same mapping so the dialog-first flow is discoverable without removing the fast path.

@kilo-code-bot

kilo-code-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Incremental review of the new commit (fix(agent-manager): restore worktree shortcut routing) added since the last review. It correctly renames the advancedWorktree binding to quickWorktree, wires the quickWorktree action to handleCreateWorktree(), renames showAdvancedWorktreeDialog to showNewWorktreeDialog, and removes the now-unused handleNewWorktreeOrPromote helper along with its onAdvanced/showAdvancedWorktreeDialog call sites. This resolves the routing/prop-naming gaps left after the prior commit and aligns the implementation with the unit tests added earlier in this PR. No dangling references to removed identifiers were found.

Files Reviewed (1 file, incremental)
  • packages/kilo-vscode/webview-ui/agent-manager/AgentManagerApp.tsx
Previous Review Summary (commit 64e9b14)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 64e9b14)

Status: No Issues Found | Recommendation: Merge

The rename of newWorktree/advancedWorktree actions and bindings is consistently threaded through extension.ts, AgentManagerApp.tsx, WorktreeSectionActions.tsx, shortcuts.ts, package.json (commands, keybindings, command-palette visibility), docs, and all 22 i18n dictionaries (verified as pure reordering with no translation content changes). New unit tests in agent-manager-arch.test.ts cover the primary button, dropdown item, shortcut dialog mapping, and command registration. Changeset is present and written from a user-facing perspective.

Files Reviewed (29 files)
  • .changeset/default-worktree-dialog.md
  • packages/kilo-docs/pages/automate/agent-manager-workflows.md
  • packages/kilo-docs/pages/automate/agent-manager.md
  • packages/kilo-vscode/package.json
  • packages/kilo-vscode/src/extension.ts
  • packages/kilo-vscode/tests/unit/agent-manager-arch.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/AgentManagerApp.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/WorktreeSectionActions.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/shortcuts.ts
  • packages/kilo-vscode/webview-ui/agent-manager/i18n/*.ts (22 locale files)

Reviewed by claude-sonnet-5 · Input: 64 · Output: 17.3K · Cached: 1.9M

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode force-pushed the change-agent-manager-plus-default branch from 822c169 to 3752722 Compare July 17, 2026 07:45
@marius-kilocode
marius-kilocode merged commit 8426d86 into main Jul 17, 2026
25 checks passed
@marius-kilocode
marius-kilocode deleted the change-agent-manager-plus-default branch July 17, 2026 09:03
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…plus-default

fix(agent-manager): open worktree dialog by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants