feat(agent-manager): stop managed sessions from tool - #12271
Merged
Conversation
marius-kilocode
enabled auto-merge
July 16, 2026 08:43
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Both previously reported warnings are resolved in this update:
Files Reviewed (4 files)
Previous Review Summary (commit c012826)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit c012826)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (15 files)
Reviewed by claude-sonnet-5 · Input: 34 · Output: 7.1K · Cached: 732.8K Review guidance: REVIEW.md from base branch |
chrarnoldus
approved these changes
Jul 17, 2026
2 tasks
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
…ssion feat(agent-manager): stop managed sessions from tool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents can inspect and prompt existing Agent Manager sessions, but they cannot currently stop a session that is no longer useful or is still running unwanted work. That leaves cleanup dependent on manually pressing the session tab close button.
Add a targeted
action: "stop"operation that requires the existing Agent Manager permission with a dedicatedstoppattern. The extension only accepts sessions owned by the current Agent Manager workspace, including live panel sessions that have not reached persisted state yet, while continuing to reject unrelated sidebar sessions. A successful stop reuses the same close path as the UI: it aborts active work, stops session background processes, clears Agent Manager routing and state, and removes the tab from the panel. Duplicate host delivery remains idempotent, so an acknowledgement retry cannot stop the session twice.This extends the provider-facing schema introduced in #12244 rather than exposing the runtime union directly. The tool schema remains a plain object root without top-level
anyOf,oneOf, orallOf, withstopadded to the flat action enum so Anthropic and Bedrock routes retain the compatibility fixed there.