feat(sandbox): widen writable-paths settings input and add coverage - #12008
Merged
Conversation
Widen the Additional Writable Paths input in the Sandboxing settings tab so long filesystem paths are readable while typing, reusing the existing wide-input variant without affecting the network toggle row. Add tests for the sandbox_writable_paths behavior: real sandbox enforcement that configured extra paths become writable while unlisted paths and .git stay denied, and a config-scope test confirming the setting is honored from global config only and dropped from project config.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by claude-sonnet-5-20260630 · Input: 38 · Output: 6.7K · Cached: 1.5M Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
July 7, 2026 12:50
chrarnoldus
approved these changes
Jul 7, 2026
This was referenced Jul 7, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
…-paths-ui-test feat(sandbox): widen writable-paths settings input and add coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11995, which added the
sandbox_writable_pathsoption and its Sandboxing settings UI.The Additional Writable Paths input inherited the default settings-row input column, which is capped at 160px. Filesystem paths are long, so the field truncated most of what the user typed and made the list of configured paths hard to scan. This widens that single row using the existing
wide-inputvariant, giving the input roughly the full control column while leaving the network toggle row unchanged.It also backfills automated coverage for behavior that previously had none:
sandbox-execenforcement inpolicy.test.ts: a configured extra path becomes writable, an unlisted sibling stays denied, and.gitinside an extra writable path is still denied.config.test.tsconfirmingsandbox_writable_pathsis honored from global config only and dropped from a projectkilo.json, so a repository cannot widen its own sandbox.