Skip to content

Show actually used models when using fable - #11969

Merged
chrarnoldus merged 2 commits into
mainfrom
fix/fable-routed-model
Jul 7, 2026
Merged

Show actually used models when using fable#11969
chrarnoldus merged 2 commits into
mainfrom
fix/fable-routed-model

Conversation

@chrarnoldus

Copy link
Copy Markdown
Collaborator
CleanShot 2026-07-06 at 15 53 06

@chrarnoldus chrarnoldus changed the title fix(cli): route fable model aliases Show actually used models when using fable Jul 6, 2026
@chrarnoldus chrarnoldus self-assigned this Jul 6, 2026
Comment thread packages/opencode/src/kilocode/session/routed-model.ts
Comment thread packages/opencode/src/kilocode/session/routed-model.ts
Comment thread packages/opencode/src/kilocode/session/routed-model.ts
@kilo-code-bot

kilo-code-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
packages/opencode/src/kilocode/session/routed-model.ts 35 Unanchored .includes("fable") substring match in isAuto, duplicated in colors.ts, still risks a false "routed model" override for a directly-selected model whose id happens to contain "fable" (carried over from previous review, unresolved)
Resolved since last review
  • N/A — this increment only touches the VS Code webview model-name display and does not change routed-model.ts
Files Reviewed (2 files)
  • packages/kilo-vscode/webview-ui/src/context/model-usage.ts - fixes modelUsageName to require whitespace after the provider-prefix colon (\s+ instead of \s*), so free-variant ids like tencent/hy3:free keep their full name instead of collapsing to free
  • packages/kilo-vscode/tests/unit/model-usage.test.ts - adds regression coverage for the :free-suffixed id case

Fix these issues in Kilo Cloud

Previous Review Summaries (2 snapshots, latest commit 143a9ac)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 143a9ac)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
packages/opencode/src/kilocode/session/routed-model.ts 35 Unanchored .includes("fable") substring match, now centralized in the new isAuto helper (and duplicated in colors.ts), still risks a false "routed model" override for a directly-selected model whose id happens to contain "fable"
Resolved since last review
  • Downstream display gates (routed-model-meta.tsx, TUI index.tsx, vscode colors.ts) now consistently use the new isAuto helper, so the fable fix is visible everywhere it needs to be
  • Test coverage added for the fable branch in readAuto
Files Reviewed (5 files)
  • packages/kilo-vscode/webview-ui/src/utils/timeline/colors.ts
  • packages/opencode/src/cli/cmd/tui/routes/session/index.tsx
  • packages/opencode/src/kilocode/cli/cmd/tui/routes/session/routed-model-meta.tsx - 1 issue (shared source)
  • packages/opencode/src/kilocode/session/routed-model.ts - 1 issue
  • packages/opencode/test/kilocode/session-routed-model.test.ts

Fix these issues in Kilo Cloud

Previous review (commit dc99ae8)

Status: 3 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 2
SUGGESTION 1
Issue Details (click to expand)

WARNING

File Line Issue
packages/opencode/src/kilocode/session/routed-model.ts 50 Downstream UI gates (routed-model-meta.tsx, TUI index.tsx, vscode colors.ts) still check modelID.startsWith("kilo-auto/") only, independent of this change, so the fix may not surface anywhere / the added .includes("fable") clause may be redundant
packages/opencode/src/kilocode/session/routed-model.ts 50 Unanchored .includes("fable") substring match, combined with write() unconditionally recording raw provider response ids every finish-step, risks a false "routed model" override for models directly selected by the user (not just auto-routed ones)

SUGGESTION

File Line Issue
packages/opencode/src/kilocode/session/routed-model.ts 50 No test case added for the new fable branch in readAuto; existing test file only covers kilo-auto/*
Files Reviewed (1 file)
  • packages/opencode/src/kilocode/session/routed-model.ts - 3 issues

Fix these issues in Kilo Cloud


Reviewed by claude-sonnet-5-20260630 · Input: 26 · Output: 6.7K · Cached: 582.9K

Review guidance: REVIEW.md from base branch main

Comment thread packages/opencode/src/kilocode/session/routed-model.ts Outdated
@chrarnoldus
chrarnoldus force-pushed the fix/fable-routed-model branch from be654f4 to dc99ae8 Compare July 7, 2026 11:35
@chrarnoldus
chrarnoldus merged commit 9858324 into main Jul 7, 2026
25 checks passed
@chrarnoldus
chrarnoldus deleted the fix/fable-routed-model branch July 7, 2026 12:50
AlexOcculate pushed a commit to AlexOcculate/kilocode that referenced this pull request Jul 14, 2026
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
Show actually used models when using fable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants