fix(cli): deny subagent permission prompts - #11916
Closed
noobezlol wants to merge 1 commit into
Closed
Conversation
Collaborator
|
@noobezlol this looks good, did you test it? |
Collaborator
|
Superseded by #11923 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11903
Summary
PermissionDeniedErrorinstead of queuing a promptbash: askrequest leaves no pending permission askTests run
bun installbun test ./test/kilocode/session-prompt-permission-refresh.test.ts -t "subagent permission asks fail"bun run typecheckfrompackages/opencodebun run script/check-opencode-annotations.tsgit diff --checkNotes / risk
session-prompt-permission-refresh.test.tsfile on this Windows D-drive sparse checkout timed out in the pre-existingactive tool calls use permissions changed after model streaming startstest after 5s; the new regression passed when run by name.