Skip to content

fix(cli): deny subagent permission prompts - #11916

Closed
noobezlol wants to merge 1 commit into
Kilo-Org:mainfrom
noobezlol:fix/11903-subagent-permission-asks
Closed

fix(cli): deny subagent permission prompts#11916
noobezlol wants to merge 1 commit into
Kilo-Org:mainfrom
noobezlol:fix/11903-subagent-permission-asks

Conversation

@noobezlol

Copy link
Copy Markdown
Contributor

Fixes #11903

Summary

  • mark subagent permission asks as non-interactive
  • make non-interactive permission asks fail immediately with PermissionDeniedError instead of queuing a prompt
  • add regression coverage that a subagent bash: ask request leaves no pending permission ask

Tests run

  • bun install
  • bun test ./test/kilocode/session-prompt-permission-refresh.test.ts -t "subagent permission asks fail"
  • bun run typecheck from packages/opencode
  • bun run script/check-opencode-annotations.ts
  • git diff --check

Notes / risk

  • Running the whole session-prompt-permission-refresh.test.ts file on this Windows D-drive sparse checkout timed out in the pre-existing active tool calls use permissions changed after model streaming starts test after 5s; the new regression passed when run by name.
  • Behavior change is limited to permission asks that would otherwise wait for a non-interactive subagent.

@marius-kilocode

Copy link
Copy Markdown
Collaborator

@noobezlol this looks good, did you test it?

@marius-kilocode

Copy link
Copy Markdown
Collaborator

Superseded by #11923

@noobezlol
noobezlol deleted the fix/11903-subagent-permission-asks branch July 4, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: subagent permission asks hang indefinitely (sync subagents treated as interactive)

2 participants