Skip to content

Add Fable and Sonnet 5 as adaptive reasoning models - #11906

Merged
chrarnoldus merged 3 commits into
mainfrom
christiaan/claude-adaptive
Jul 3, 2026
Merged

Add Fable and Sonnet 5 as adaptive reasoning models#11906
chrarnoldus merged 3 commits into
mainfrom
christiaan/claude-adaptive

Conversation

@chrarnoldus

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread packages/opencode/src/provider/transform.ts
Comment thread packages/opencode/src/plugin/github-copilot/models.ts
@kilo-code-bot

kilo-code-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 2
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/opencode/src/provider/transform.ts 618 anthropicClaude5 isn't exported, so models.ts duplicates the same fable/sonnet-5 matching logic inline instead of reusing it
packages/opencode/src/plugin/github-copilot/models.ts 130 Inline opus-4.7/4.8/fable/sonnet-5 check duplicates (with a slightly different pattern) the logic in transform.ts's anthropicOpus47OrLater/anthropicClaude5

Notes

  • Latest commit (1d3a9e03, "chore(cli): add adaptive reasoning changeset") adds .changeset/claude-adaptive-reasoning.md, resolving the previous review's missing-changeset note. The description is concise and user-facing ("Support adaptive reasoning presets for Claude Fable and Sonnet 5 models."), correctly scoped as a patch.
  • The pre-existing duplication issue between transform.ts and models.ts (see above) is unchanged in this increment and still applies.
Files Reviewed (4 files)
  • .changeset/claude-adaptive-reasoning.md - no issues
  • packages/opencode/src/plugin/github-copilot/models.ts - 1 issue (unchanged since last review)
  • packages/opencode/src/provider/transform.ts - 1 issue (unchanged since last review)
  • packages/opencode/test/kilocode/transform-opus-4.7.test.ts - no issues (unchanged since last review)

Fix these issues in Kilo Cloud

Previous Review Summaries (2 snapshots, latest commit daca72c)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit daca72c)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 2
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/opencode/src/provider/transform.ts 618 anthropicClaude5 isn't exported, so models.ts duplicates the same fable/sonnet-5 matching logic inline instead of reusing it
packages/opencode/src/plugin/github-copilot/models.ts 130 Inline opus-4.7/4.8/fable/sonnet-5 check duplicates (with a slightly different pattern) the logic in transform.ts's anthropicOpus47OrLater/anthropicClaude5

Notes

  • Latest commit (daca72c, "Simplify") only tightened the inline check in models.ts (dropped an unnecessary .toLowerCase()/regex in favor of plain .includes("sonnet-5"), matching the style of the adjacent opus-4.7/opus-4.8 checks). Verified against the PR's test fixtures (claude-fable-5, claude-sonnet-5, anthropic.claude-sonnet-5) — all use lowercase hyphenated IDs, so this is a safe simplification, not a regression. The pre-existing duplication issue (see above) still applies to this line.
  • No .changeset/*.md was added. This PR extends user-facing adaptive-thinking model support (mirrors the earlier opus-4.8 PR feat(cli): treat opus 4.8 as adaptive thinking model like 4.7 #10735, which included a changeset) — consider adding one.
Files Reviewed (3 files)
  • packages/opencode/src/plugin/github-copilot/models.ts - 1 issue
  • packages/opencode/src/provider/transform.ts - 1 issue
  • packages/opencode/test/kilocode/transform-opus-4.7.test.ts - no issues

Fix these issues in Kilo Cloud

Previous review (commit b0f90c0)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 2
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/opencode/src/provider/transform.ts 618 anthropicClaude5 isn't exported, so models.ts duplicates the same fable/sonnet-5 matching logic inline instead of reusing it
packages/opencode/src/plugin/github-copilot/models.ts 130 Inline opus-4.7/4.8/fable/sonnet-5 check duplicates (with a slightly different pattern) the logic in transform.ts's anthropicOpus47OrLater/anthropicClaude5

Notes

  • No .changeset/*.md was added. This PR extends user-facing adaptive-thinking model support (mirrors the earlier opus-4.8 PR feat(cli): treat opus 4.8 as adaptive thinking model like 4.7 #10735, which included a changeset) — consider adding one.
  • Regex/logic changes were checked for false positives (e.g. sonnet-4.5 does not match /sonnet[.-]5/) and look correct.
  • New tests exercise the real ProviderTransform.variants implementation without unnecessary mocking.
Files Reviewed (3 files)
  • packages/opencode/src/plugin/github-copilot/models.ts - 1 issue
  • packages/opencode/src/provider/transform.ts - 1 issue
  • packages/opencode/test/kilocode/transform-opus-4.7.test.ts - no issues

Fix these issues in Kilo Cloud


Reviewed by claude-sonnet-5-20260630 · Input: 20 · Output: 4.8K · Cached: 382.6K

Review guidance: REVIEW.md from base branch main

Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@chrarnoldus
chrarnoldus merged commit bd8a22b into main Jul 3, 2026
27 checks passed
@chrarnoldus
chrarnoldus deleted the christiaan/claude-adaptive branch July 3, 2026 12:14
NJ-2020 pushed a commit to NJ-2020/kilocode that referenced this pull request Jul 4, 2026
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…ptive

Add Fable and Sonnet 5 as adaptive reasoning models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants