fix(jetbrains): polish session links and tool popups by kirillk · Pull Request #11871 · Kilo-Org/kilocode

kirillk · 2026-07-01T19:09:05Z

What

Add workspace-aware JetBrains session file links with fallback search and missing-file warnings.
Improve markdown/file-reference inline styling and clear link hover state on scroll.
Keep shell tool headers clipped, add a full command popup for collapsed shell runs, and show that popup regardless of header cropping.
Make todo checklist rows visually consistent with higher-contrast read-only checkboxes.

Why

These changes bring JetBrains session rendering closer to VS Code behavior and make linked files, shell commands, and todo status easier to read and use from the chat transcript.

Demo and screenshots

Links to the files

Bad link

ToDo view

Shell run hints

Testing

./gradlew :frontend:test --tests "ai.kilocode.client.session.views.todo.TodoWriteViewTest" --rerun-tasks
./gradlew :frontend:test --tests "ai.kilocode.client.session.views.ShellToolViewTest" --tests "ai.kilocode.client.session.SessionFileLinksTest" --rerun-tasks
./gradlew typecheck
bun turbo typecheck

Add a hover popup for collapsed Shell tool headers whose command subtitle is cropped. The popup renders the full command in the shell code-block editor, breaking on shell separators (&&, ||, |, ;) outside quotes, and shares the editor background. It appears after a 500ms dwell and hides 250ms after the mouse leaves both the header and the popup, so the user can move into the popup without it disappearing.

# Conflicts: # packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/SessionUi.kt

kilo-code-bot · 2026-07-01T19:34:56Z

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Incremental review of the latest commit (fix(jetbrains): keep progress body during session open), which touches only SessionUi.kt. The change:

ViewChanged.ShowSession now shows body(controller.model.state) instead of unconditionally showing messageBody, so re-entering the session view while state is Loading/Retry/Offline correctly shows the progress body instead of forcing the (possibly empty) message list. This mirrors the existing onStateChanged behavior, which already derives the shown panel from body(state).
resumeOpen() gains a guard that skips the scroll-to-bottom "open" animation while the currently-selected body isn't messageBody, preventing it from operating on the wrong panel. Any subsequent state change re-triggers layout validation (via refresh() → root.revalidate()), which re-invokes resumeOpen() once the message body becomes current, so pending/opening do not get stuck.

No new issues found in this pass.

Files Reviewed in this incremental pass (1 file)

packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/SessionUi.kt

Previous Review Summaries (5 snapshots, latest commit d916e10)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit `d916e10`)

Status: No Issues Found | Recommendation: Merge

Incremental review of the latest commit, which adds HeaderPopupControllerTest.kt only. This test file directly exercises the guard-disposal mechanism previously flagged as missing coverage:

test guard is disposed between repeated hover cycles verifies the guard field is cleared and the prior guard Disposable is disposed on both notifyExit and hideAll, and that a fresh, distinct guard is created on the next show().
test disposing hovered view clears pending guard and suppresses popup verifies that disposing the hovered PartView clears the pending guard, clears target, and suppresses the popup (headerPopup() is never invoked).

Both tests correctly reflect the current HeaderPopupController implementation (guard registered via Disposer.register(view, it), captured and disposed inside hideAll(), and the self-nulling dispose to avoid double-dispose). No new issues found in this pass.

Files Reviewed in this incremental pass (1 file)

packages/kilo-jetbrains/frontend/src/test/kotlin/ai/kilocode/client/session/ui/popup/HeaderPopupControllerTest.kt

Previous review (commit `77c6579`)

Status: No Issues Found | Recommendation: Merge

Incremental review of the latest commit (fix(jetbrains): clean up header popup disposal guard), which touches only HeaderPopupController.kt. The change correctly resolves both previously-flagged findings on this file:

The disposal-safety-net issue (no guard against the hovered PartView being disposed while a popup is pending/showing) is now fixed via an explicit guard: Disposable registered on view.
The follow-up leak (each show() call registered a new, never-cleaned-up child Disposable on view) is now fixed: hideAll() captures and explicitly disposes the prior guard before it is cleared/replaced, and the guard nulls itself first to avoid a double-dispose loop when the platform disposes view directly.

One new SUGGESTION was raised: this disposal-safety mechanism still has no dedicated test coverage.

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	1

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
`HeaderPopupController.kt`	49	No test exercises the guard-disposal fix (no accumulation across `show()` calls, no double-dispose when the hovered view is disposed)

Files Reviewed in this incremental pass (1 file)

packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/popup/HeaderPopupController.kt

Previous review (commit `cfa4705`)

Status: 1 Issue Found | Recommendation: Address before merge

Incremental review since the last pass: all 10 previously-flagged findings (MdCommon.kt false-positive links + dead replace, SessionFileLinks.kt HTML escaping + fallback-search decoding, PromptView.kt import style, TextView.kt link-routing duplication, TodoListPanel.kt checkbox accessibility + icon reallocation, SessionFileLinksTest.kt missing coverage) were verified fixed in the follow-up commits and are no longer flagged. One new issue was introduced by the disposal-safety fix for HeaderPopupController.kt.

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

WARNING

File	Line	Issue
`HeaderPopupController.kt`	48	New `Disposer.register` call on every cold `show()` leaks one child disposable per hover cycle on long-lived `PartView`s

Files Reviewed in this incremental pass (49 files)

.changeset/*.md (6 changesets)
packages/kilo-jetbrains/backend/src/main/kotlin/ai/kilocode/backend/rpc/KiloWorkspaceRpcApiImpl.kt
packages/kilo-jetbrains/backend/src/test/kotlin/ai/kilocode/backend/rpc/WorkspacePathScopingTest.kt
packages/kilo-jetbrains/shared/src/main/kotlin/ai/kilocode/rpc/WorkspacePath.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/app/KiloWorkspaceService.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/SessionFileLinks.kt (fixes verified: HTML escaping, decoded fallback search)
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/SessionUi.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/SessionMessageListPanel.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/popup/HeaderPopup.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/popup/HeaderPopupController.kt (new leak, see above)
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/base/PartView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/tool/{ShellToolView,ReadToolView,ToolSupport}.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/{AttachmentView,MessageView,PlanExitView,PromptView,ReasoningView,TextView,TurnView,ViewFactory}.kt (fixes verified: shared openSessionLink helper, MdView import)
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/todo/{TodoListPanel,TodoWriteView}.kt (fixes verified: accessible name/description, icon-reuse short-circuit)
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/ui/md/MdCommon.kt (fixes verified: pathish() guard against bare framework names, dead unescape removed)
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/ui/md/hybrid/MdViewHybrid.kt
packages/kilo-jetbrains/frontend/src/main/resources/messages/KiloBundle*.properties (i18n additions)
plus 20 corresponding test files under frontend/src/test/ and backend/src/test/, including new SessionFileLinksTest coverage for open() fallback search (fix verified)

Fix these issues in Kilo Cloud

Previous review (commit `5d04269`)

Status: 10 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	5
SUGGESTION	5

Issue Details (click to expand)

WARNING

File	Line	Issue
`MdCommon.kt`	21	New file-ref auto-link regex false-positives on tokens like Next.js/Node.js/Vue.js
`SessionFileLinks.kt`	69	Unescaped path interpolated into HTML balloon markup
`SessionFileLinks.kt`	40	Fallback search uses raw percent-encoded basename as query, missing real matches
`HeaderPopupController.kt`	40	No disposal safety net if hovered PartView is disposed while popup pending/showing
`TodoListPanel.kt`	117	Read-only checkbox accessibility regression (JBCheckBox to plain JBLabel+Icon)

SUGGESTION

File	Line	Issue
`MdCommon.kt`	157	Dead/unreachable defensive `&` replace
`TodoListPanel.kt`	135	Icon reallocated unconditionally on every update() call
`PromptView.kt`	62	Fully-qualified type name instead of import (style inconsistency)
`TextView.kt`	88	Link-routing logic duplicated across TextView/PlanExitView/ReasoningView
`SessionFileLinksTest.kt`	6	No test coverage for `open()` fallback-search / missing-file behavior

Files Reviewed (49 files)

.changeset/*.md (6 changesets — clear, user-facing, no issues)
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/ui/md/MdCommon.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/ui/md/MdView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/ui/md/MdViewFactory.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/ui/md/hybrid/MdViewHybrid.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/SessionFileLinks.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/SessionUi.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/SessionMessageListPanel.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/popup/HeaderPopup.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/popup/HeaderPopupController.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/style/SessionUiStyle.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/tool/ShellToolView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/tool/ToolSupport.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/tool/ReadToolView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/base/PartView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/todo/TodoListPanel.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/todo/TodoWriteView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/AttachmentView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/MessageView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/PlanExitView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/PromptView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/ReasoningView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/TextView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/TurnView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/ViewFactory.kt
packages/kilo-jetbrains/backend/src/main/kotlin/ai/kilocode/backend/rpc/KiloWorkspaceRpcApiImpl.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/app/KiloWorkspaceService.kt
packages/kilo-jetbrains/shared/src/main/kotlin/ai/kilocode/rpc/KiloWorkspaceRpcApi.kt
packages/kilo-jetbrains/frontend/src/main/resources/messages/KiloBundle.properties
plus 20 corresponding test files under frontend/src/test/ and backend/src/test/

Fix these issues in Kilo Cloud

Previous review (commit `3365d00`)

Status: 10 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	5
SUGGESTION	5

Issue Details (click to expand)

WARNING

File	Line	Issue
`MdCommon.kt`	21	New file-ref auto-link regex false-positives on tokens like Next.js/Node.js/Vue.js
`SessionFileLinks.kt`	69	Unescaped path interpolated into HTML balloon markup
`SessionFileLinks.kt`	40	Fallback search uses raw percent-encoded basename as query, missing real matches
`HeaderPopupController.kt`	40	No disposal safety net if hovered PartView is disposed while popup pending/showing
`TodoListPanel.kt`	117	Read-only checkbox accessibility regression (JBCheckBox to plain JBLabel+Icon)

SUGGESTION

File	Line	Issue
`MdCommon.kt`	157	Dead/unreachable defensive `&` replace
`TodoListPanel.kt`	135	Icon reallocated unconditionally on every update() call
`PromptView.kt`	62	Fully-qualified type name instead of import (style inconsistency)
`TextView.kt`	88	Link-routing logic duplicated across TextView/PlanExitView/ReasoningView
`SessionFileLinksTest.kt`	6	No test coverage for `open()` fallback-search / missing-file behavior

Files Reviewed (49 files)

.changeset/*.md (6 changesets — clear, user-facing, no issues)
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/ui/md/MdCommon.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/ui/md/MdView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/ui/md/MdViewFactory.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/ui/md/hybrid/MdViewHybrid.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/SessionFileLinks.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/SessionUi.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/SessionMessageListPanel.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/popup/HeaderPopup.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/popup/HeaderPopupController.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/style/SessionUiStyle.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/tool/ShellToolView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/tool/ToolSupport.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/tool/ReadToolView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/base/PartView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/todo/TodoListPanel.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/todo/TodoWriteView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/AttachmentView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/MessageView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/PlanExitView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/PromptView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/ReasoningView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/TextView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/TurnView.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/views/ViewFactory.kt
packages/kilo-jetbrains/backend/src/main/kotlin/ai/kilocode/backend/rpc/KiloWorkspaceRpcApiImpl.kt
packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/app/KiloWorkspaceService.kt
packages/kilo-jetbrains/shared/src/main/kotlin/ai/kilocode/rpc/KiloWorkspaceRpcApi.kt
packages/kilo-jetbrains/frontend/src/main/resources/messages/KiloBundle.properties
plus 20 corresponding test files under frontend/src/test/ and backend/src/test/

Fix these issues in Kilo Cloud

_{Reviewed by claude-sonnet-5-20260630 · Input: 50 · Output: 14.8K · Cached: 1.6M}

_{Review guidance: REVIEW.md from base branch main}

fix(jetbrains): polish session links and tool popups

kirillk added 8 commits June 30, 2026 10:46

fix(jetbrains): align markdown inline styling

07f1e27

fix(jetbrains): clip tool headers to one line

112e7d7

fix(jetbrains): open session file links in workspace

95b1d54

fix(jetbrains): clear session link hover on scroll

06231f9

fix(jetbrains): improve checklist styling

73bdb92

fix(jetbrains): simplify session popups

521a8ff

Merge remote-tracking branch 'origin/main' into efficacious-fern

3365d00

# Conflicts: # packages/kilo-jetbrains/frontend/src/main/kotlin/ai/kilocode/client/session/SessionUi.kt

kilo-code-bot Bot reviewed Jul 1, 2026

View reviewed changes

kirillk added 3 commits July 1, 2026 15:37

fix(jetbrains): address session UI review feedback

42995d2

fix(jetbrains): address session UI review comments

5d04269

fix(jetbrains): guard prompt hover in headless tests

cfa4705

kilo-code-bot Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread ...brains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/popup/HeaderPopupController.kt Outdated

catrielmuller approved these changes Jul 1, 2026

View reviewed changes

fix(jetbrains): clean up header popup disposal guard

77c6579

kilo-code-bot Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread ...brains/frontend/src/main/kotlin/ai/kilocode/client/session/ui/popup/HeaderPopupController.kt

kirillk added 2 commits July 1, 2026 20:20

test(jetbrains): cover header popup disposal guard

d916e10

fix(jetbrains): keep progress body during session open

872d7c5

kirillk merged commit bfb630d into main Jul 2, 2026
21 checks passed

kirillk deleted the efficacious-fern branch July 2, 2026 11:40

kilo-maintainer Bot mentioned this pull request Jul 2, 2026

release(jetbrains): v7.0.1-rc.14 #11897

Merged

t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026

Merge pull request Kilo-Org#11871 from Kilo-Org/efficacious-fern

6306d81

fix(jetbrains): polish session links and tool popups

Uh oh!

Conversation

kirillk commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Demo and screenshots

Links to the files

Bad link

ToDo view

Shell run hints

Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kilo-code-bot Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Previous review (commit d916e10)

Previous review (commit 77c6579)

Overview

SUGGESTION

Previous review (commit cfa4705)

Overview

WARNING

Previous review (commit 5d04269)

Overview

WARNING

SUGGESTION

Previous review (commit 3365d00)

Overview

WARNING

SUGGESTION

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kirillk commented Jul 1, 2026 •

edited

Loading

kilo-code-bot Bot commented Jul 1, 2026 •

edited

Loading

Previous review (commit `d916e10`)

Previous review (commit `77c6579`)

Previous review (commit `cfa4705`)

Previous review (commit `5d04269`)

Previous review (commit `3365d00`)