fix(agent-manager): persist sandbox default in worktree dialog - #11792
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Previous Review Summary (commit 401e0fd)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 401e0fd)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Fix these issues in Kilo Cloud Files Reviewed (6 files)
Reviewed by gpt-5.4-20260305 · Input: 49.3K · Output: 7.3K · Cached: 209.7K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
June 29, 2026 12:38
chrarnoldus
approved these changes
Jun 29, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
fix(agent-manager): persist sandbox default in worktree dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a merge regression.
The Agent Manager new-worktree modal was deriving its sandbox toggle from the experimental sandbox config instead of the persisted new-session sandbox default. When sandboxing was disabled as the default, reopening the modal still showed sandboxing enabled and newly created Agent Manager sessions could be forced back into sandbox mode.
This changes the modal to load the persisted sandbox default, save modal toggle changes through the same default-setting path used by the prompt input, and correlate sandbox default responses with the modal request. The modal now only sends a create-session sandbox override while a local change is still pending, so new worktree sessions follow the saved preference instead of reverting to the config default.
This fixes unselecting sandboxing in the Agent Manager create modal, closing and reopening the modal, and seeing sandboxing selected again.