fix(ui): keep mention highlights after slash command expansion - #11777
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Previous Review Summaries (2 snapshots, latest commit 3219a06)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 3219a06)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous review (commit ff427e5)Status: 1 Issue Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Files Reviewed (4 files)
Reviewed by gpt-5.4-20260305 · Input: 48.8K · Output: 6.1K · Cached: 194.6K Review guidance: REVIEW.md from base branch |
chrarnoldus
approved these changes
Jun 29, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
fix(ui): keep mention highlights after slash command expansion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered user messages color inline @mentions by using source offsets from attachments. When a slash command expands or rewrites the displayed text before an attachment mention, those offsets can become stale and highlight unrelated words instead of the actual mention.
This change moves message highlight segmentation into a focused helper that first verifies the stored range still matches the original source value. If the range is stale, it relocates the highlight by the source value in the rendered text, while preserving the existing regex fallback for plain path mentions. This keeps @git-changes and other attachment mentions visually aligned with the text the user sees after command expansion.
Prompt:

Before:

After:
