fix(vscode): add full Anaconda Desktop translations to all 19 locale files - #11772
Closed
markijbema wants to merge 1 commit into
Closed
fix(vscode): add full Anaconda Desktop translations to all 19 locale files#11772markijbema wants to merge 1 commit into
markijbema wants to merge 1 commit into
Conversation
…files - Remove the anacondaDesktopDict spread hack from en.ts and all locale files - Move all Anaconda Desktop keys directly into the main dict in en.ts - Add proper native-language translations for all 36 Anaconda Desktop keys in ar, br, bs, da, de, es, fr, it, ja, ko, nl, no, pl, ru, th, tr, uk, zh, zht - Previously only 3 keys had translations (checkAgain, noServer_one, noServer_other); the remaining 33 keys were falling back to English via the spread Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (20 files)
Reviewed by gpt-5.4-20260305 · Input: 111.5K · Output: 12.8K · Cached: 1.1M Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixed incomplete translations introduced by PR #11714 (Anaconda Desktop provider).
anacondaDesktopDictspread hack fromen.tsand all 19 locale files. Previously, all Anaconda Desktop strings were exported as a separateanacondaDesktopDictconstant that was spread into each locale'sdict, causing 33 of 36 new keys to silently fall back to English.dictinen.ts.Before / After
Before: only 3 keys had translations per locale (
checkAgain,noServer_one,noServer_other); the remaining 33 Anaconda Desktop strings (titles, status messages, state descriptions, tool support warnings, toast notifications, etc.) were showing in English for all non-English users.After: all 36 Anaconda Desktop keys are fully translated in every supported language.
Built for Mark IJbema by Kilo for Slack