fix(vscode): wait for microphone capture readiness - #11738
Closed
marius-kilocode wants to merge 3 commits into
Closed
fix(vscode): wait for microphone capture readiness#11738marius-kilocode wants to merge 3 commits into
marius-kilocode wants to merge 3 commits into
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| } | ||
|
|
||
| const click = () => { | ||
| if (props.speech.state() === "starting") return |
Contributor
There was a problem hiding this comment.
WARNING: Starting state cannot be cancelled from the button
The new state machine and tests explicitly support cancelling a pending microphone startup, but this early return swallows the only user action while the spinner is shown. If opening the capture device hangs for a few seconds or the permission flow stalls, the user has to wait for timeout or for the recording to become ready before they can recover. Letting the second click call speech.cancel() would preserve the new readiness indicator without removing the escape hatch.
Suggested change
| if (props.speech.state() === "starting") return | |
| if (props.speech.state() === "starting") return props.speech.cancel() |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (32 files)
Fix these issues in Kilo Cloud Previous Review Summary (commit b51b16e)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit b51b16e)Status: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (32 files)
Reviewed by gpt-5.4-20260305 · Input: 81.2K · Output: 11.9K · Cached: 437.2K Review guidance: REVIEW.md from base branch |
chrarnoldus
approved these changes
Jun 29, 2026
Run the prewarm child from webview-ui so JSX resolves via solid-js instead of falling back to react/jsx-dev-runtime, which only resolved when react happened to be hoisted nearby and otherwise failed the spawn at ~80ms. Assert on an explicit PASS/FAIL sentinel: real prewarm-logic failures surface immediately while transient spawn failures retry.
Contributor
|
To stay organized pull requests are automatically closed after 30 days of inactivity. If the pull request is still relevant please reopen it or create a fresh new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speech input currently appears to be recording as soon as the microphone button is clicked, even though FFmpeg and the operating system may still be opening the capture device. Speech during that gap is not recorded, which is especially noticeable on the first recording after startup.
Introduce an explicit microphone-starting state and keep the loading indicator visible until the extension confirms that audio capture is ready. The recording indicator now marks the actual point when users can begin speaking.
Prewarm only FFmpeg binary discovery for users who have Kilo speech access, without opening the microphone or prompting for permission. Signed-out users and users with Kilo disabled do not run the prewarm, and failed discovery remains retryable when recording starts.