test(jetbrains): stabilize workspace reload lifecycle - #11730
Merged
Conversation
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Previous Review Summaries (4 snapshots, latest commit 3ae6d2b)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 3ae6d2b)Status: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Previous review (commit 4e2fb78)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous review (commit f6ca368)Status: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Previous review (commit 90b6b2e)Status: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · Input: 55.9K · Output: 4.9K · Cached: 184.8K Review guidance: REVIEW.md from base branch |
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
markijbema
enabled auto-merge
June 29, 2026 08:19
marius-kilocode
approved these changes
Jun 29, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
…rkspace-flake test(jetbrains): stabilize workspace reload lifecycle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Make
KiloBackendWorkspaceTestwait for its coroutine scope to finish during teardown and close the mock server before joining so blocked requests are released. Theglobal.disposedtest now subscribes before sending the SSE event, waits for the nextReadystate instead of accepting the existing one after an arbitrary delay, and verifies that reload replaced the cached workspace.Why
The failed job timed out while setting up this test after the preceding concurrent-reload test. Teardown cancelled asynchronous work without joining it, allowing request and watcher jobs to outlive their test fixture. The disposed-event assertion also treated the pre-event
Readystate as proof that reload finished. Causal event synchronization and complete fixture cleanup remove both races without extending normal test waits.Investigated failure: https://github.com/Kilo-Org/kilocode/actions/runs/28236011741/job/83650998502?pr=11726