fix(vscode): reset read notifications from settings - #11716
Merged
Conversation
markijbema
marked this pull request as ready for review
June 26, 2026 09:26
markijbema
enabled auto-merge
June 26, 2026 09:26
imanolmzd-svg
approved these changes
Jun 26, 2026
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| if (cached) { | ||
| const persisted = ctx.context?.globalState.get<string[]>(KEY, []) ?? [] | ||
| const dismissedIds = | ||
| persisted.length > 0 ? Array.from(new Set([...cached.dismissedIds, ...persisted])) : cached.dismissedIds |
Contributor
There was a problem hiding this comment.
WARNING: Resetting while the extension is offline still republishes the cached dismissed IDs
resetReadNotifications() clears globalState, but this branch treats an empty persisted list as a signal to fall back to cached.dismissedIds. If the user clicks the new settings button before the client reconnects, notificationsLoaded goes back out with the old IDs, so the notifications stay hidden even though the success toast is shown. Letting an empty persisted list win here, or special-casing the reset path, would make the new action work offline as well.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (25 files)
Fix these issues in Kilo Cloud Reviewed by gpt-5.4-20260305 · Input: 79.4K · Output: 13.6K · Cached: 596.7K Review guidance: REVIEW.md from base branch |
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
…ications fix(vscode): reset read notifications from settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
kilo.dismissedNotificationIdsand refresh notifications without resetting other settings.Why
Users need a targeted way to make previously read notifications visible again without using the broader settings reset.
Validation
bun run formatfrompackages/kilo-vscode/bun run typecheckfrompackages/kilo-vscode/bun run lintfrompackages/kilo-vscode/bun test tests/unit/message-contract.test.ts tests/unit/i18n-keys.test.tsfrompackages/kilo-vscode/