Skip to content

feat(vscode): notify on matching marketplace items - #11698

Merged
markijbema merged 2 commits into
mainfrom
mark/marketplace-match-notification
Jun 26, 2026
Merged

feat(vscode): notify on matching marketplace items#11698
markijbema merged 2 commits into
mainfrom
mark/marketplace-match-notification

Conversation

@markijbema

@markijbema markijbema commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Chained on top of #11640 (mark/marketplace-relevance-filter).

Builds on the workspace-relevance filter by proactively surfacing matches as a native VS Code notification, so users discover relevant skills/agents/MCP servers without opening the marketplace.

What

  • A background MarketplaceNotifier scans the workspace shortly after activation (and on workspace-folder/extension/file changes), reusing the existing relevance detection.
  • When a non-installed item's suggest_for metadata matches, it shows a toast: Install and Don't show again.
  • Install opens the marketplace panel's existing install dialog for that item, with project scope preselected — so scope/parameter selection still happens in the normal popup.
  • Don't show again persists a stable, discardable type:id slug in globalState; dismissed items never re-notify and the list is cleared on settings reset.

Why

The relevance filter only helps users who already opened the marketplace. This closes the loop by bringing relevant suggestions to them, while keeping them fully discardable and non-repeating.

Notes

  • Only one suggestion is surfaced per scan to avoid stacking toasts.
  • Selection logic (selectSuggestions / suggestionSlug) is pure and unit-tested without VS Code.

Screenshots:

CleanShot 2026-06-26 at 13 21 57

After clicking install

CleanShot 2026-06-26 at 13 23 20

Base automatically changed from mark/marketplace-relevance-filter to main June 25, 2026 15:25
Surface a discardable VS Code notification when a marketplace item's suggest_for metadata matches the current workspace. The notification offers a one-click Install button that opens the marketplace install dialog with project scope preselected, plus a per-suggestion "Don't show again" option persisted via a stable type:id slug.
@markijbema
markijbema force-pushed the mark/marketplace-match-notification branch from 6a57cf3 to 80ed571 Compare June 26, 2026 08:29
@markijbema
markijbema marked this pull request as ready for review June 26, 2026 10:59
Comment thread packages/kilo-vscode/src/services/marketplace/notifier.ts
Comment thread packages/kilo-vscode/src/services/marketplace/notifier.ts Outdated
@kilo-code-bot

kilo-code-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File Line Issue
packages/kilo-vscode/src/services/marketplace/notifier.ts 114 Closing the toast suppresses the suggestion for the rest of the session.
Files Reviewed (1 file)
  • packages/kilo-vscode/src/services/marketplace/notifier.ts - 1 issue
Previous Review Summary (commit 80ed571)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 80ed571)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 2
SUGGESTION 0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File Line Issue
packages/kilo-vscode/src/services/marketplace/notifier.ts 112 Closing the toast suppresses the suggestion for the rest of the session.
packages/kilo-vscode/src/services/marketplace/notifier.ts 115 A later rescan can drop the user's notification choice.
Files Reviewed (9 files)
  • .changeset/marketplace-match-notification.md
  • packages/kilo-vscode/src/KiloProvider.ts
  • packages/kilo-vscode/src/MarketplacePanelProvider.ts
  • packages/kilo-vscode/src/extension.ts
  • packages/kilo-vscode/src/services/marketplace/notifier.ts - 2 issues
  • packages/kilo-vscode/src/services/marketplace/notify.ts
  • packages/kilo-vscode/tests/unit/marketplace-notify.test.ts
  • packages/kilo-vscode/webview-ui/src/components/marketplace/MarketplaceView.tsx
  • packages/kilo-vscode/webview-ui/src/types/messages/extension-messages.ts

Reviewed by gpt-5.4-20260305 · Input: 43.2K · Output: 6K · Cached: 184.3K

Review guidance: REVIEW.md from base branch main

A background rescan bumped generation while a suggestion toast was open, so a later Install or dismiss click hit the stale-scan early return and was silently dropped. Guard the post-toast path on a disposed flag instead, so only teardown can discard the user's choice.
@markijbema
markijbema merged commit e245fde into main Jun 26, 2026
25 checks passed
@markijbema
markijbema deleted the mark/marketplace-match-notification branch June 26, 2026 11:37
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…h-notification

feat(vscode): notify on matching marketplace items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants